Skip to content

Commit f341000

Browse files
committed
fix: prevent sending empty results set
1 parent 3adae9d commit f341000

File tree

4 files changed

+18
-0
lines changed

4 files changed

+18
-0
lines changed

src/i18n/locales/de.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@
117117
"leave": "Projekt verlassen",
118118
"saveResults": "Speichern",
119119
"AreYouSureYouWantToLeave": "Bist du sicher, dass du das Projekt verlassen möchtest? Deine Beiträge gehen verloren.",
120+
"noResults": "Keine Ergebnisse",
121+
"checkConnection": "Überprüfe deine Internetverbindung und Browsereinstellungen, um sicherzustellen, dass Inhalte geladen werden können.",
120122
"saveFailed": "Ergebnisse konnten nicht gespeichert werden",
121123
"resultsSaved": "Danke, {user}! Dein Beitrag wurde gespeichert.",
122124
"wellDone": "Gut gemacht, {user}!",

src/i18n/locales/en.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@
116116
"projectView": {
117117
"leave": "Leave project",
118118
"AreYouSureYouWantToLeave": "Are you sure you want to leave the project? Your contributions will be lost.",
119+
"noResults": "No results to save",
120+
"checkConnection": "Check your internet connection and browser settings to make sure that contents can be loaded",
119121
"saveResults": "Save",
120122
"saveFailed": "Failed to save results",
121123
"resultsSaved": "Thanks, {user}! Your contribution has been saved.",

src/i18n/locales/fr.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@
116116
"projectView": {
117117
"leave": "Quitter le projet",
118118
"AreYouSureYouWantToLeave": "Êtes-vous certain de vouloir quitter le projet ? Vos contributions seront perdues.",
119+
"noResults": "Aucun résultat à sauvegarder",
120+
"checkConnection": "Vérifiez votre connexion Internet et les paramètres de votre navigateur pour vous assurer que le contenu peut être chargé.",
119121
"saveResults": "Sauvegarder",
120122
"saveFailed": "Impossible de sauvegarder vos résultats",
121123
"resultsSaved": "Merci, {user} ! Votre contribution a été sauvegardée.",

src/views/ProjectView.vue

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,18 @@ export default defineComponent({
5656
logAnalyticsEvent('mapping_started', { projectType: projectType })
5757
},
5858
saveResults: (results, startTime) => {
59+
if (Object.values(results).every((v) => v === null)) {
60+
this.to = this.i18nRoute({ name: 'projects' })
61+
this.showDialog(
62+
this.$t('projectView.noResults'),
63+
this.$t('projectView.checkConnection'),
64+
this.leaveProject,
65+
true,
66+
false,
67+
)
68+
return 0
69+
}
70+
5971
const numberOfTasks = Object.keys(results).length
6072
const endTime = new Date().toISOString()
6173
const dev = import.meta.env.DEV

0 commit comments

Comments
 (0)