raise customError when project creation fails

Author: Hagellach37

mapswipe_workers/mapswipe_workers/base/base_project.py

@@ -8,6 +8,7 @@
 from mapswipe_workers import auth
 from mapswipe_workers.definitions import DATA_PATH
 from mapswipe_workers.definitions import logger
+from mapswipe_workers.definitions import CustomError
 
 
 class BaseProject(metaclass=ABCMeta):
@@ -137,22 +138,24 @@ def save_project(self, fb_db):
                         f' to firebase'
                         )
                 return True
-            except Exception:
+            except Exception as e:
                 self.delete_from_postgres()
                 logger.exception(
                         f'{self.projectId}'
                         f' - the project could not be saved'
                         f' to firebase. '
                         )
-                return False
-        except Exception:
+
+                logger.info(f'{self.projectId} deleted project data from postgres')
+                raise CustomError(e)
+        except Exception as e:
             logger.exception(
                     f'{self.projectId}'
                     f' - the project could not be saved'
                     f' to postgres and will therefor not be '
                     f' saved to firebase'
                     )
-            return False
+            raise CustomError
 
     def save_to_firebase(self, fb_db, project, groups, groupsOfTasks):
 

mapswipe_workers/mapswipe_workers/mapswipe_workers.py

@@ -361,17 +361,6 @@ def _run_create_projects(project_draft_ids=None):
                             )
                     slack.send_slack_message(message)
                     logger.info(message)
-                else:
-                    newline = '\n'
-                    message = (
-                        f'### PROJECT CREATION FAILED ###{newline}'
-                        f'Project Name: {project_draft["name"]}{newline}'
-                        f'Project Id: {project_draft_id}{newline}'
-                        f'{newline}'
-                        f'Project draft is deleted.{newline}'
-                        f'Please check what went wrong.'
-                    )
-                    slack.send_slack_message(message)
             except CustomError:
                 ref = fb_db.reference(f'v2/projectDrafts/{project_draft_id}')
                 ref.set({})