Improve cloud function

Author: puranban

firebase/functions/src/index.ts

@@ -346,16 +346,15 @@ exports.decProjectProgress = functions.database.ref('/v2/projects/{projectId}/re
 
 exports.addProjectTopicKey = functions.https.onRequest(async (_, res) => {
     try {
-        const projectRef = admin.database().ref('v2/projects');
-        const snapshot = projectRef.once('value');
-        const data = (await snapshot).val();
+        const projectRef = await admin.database().ref('v2/projects').once('value');
+        const data = projectRef.val();
 
         if (data) {
             const newProjectData: {[key: string]: string} = {};
 
             Object.keys(data).forEach((id) => {
                 if (data[id]?.projectTopic) {
-                    const newProjectTopicKey = data[id]?.projectTopic?.toLowerCase() as string;
+                    const newProjectTopicKey = data[id].projectTopic?.toLowerCase() as string;
                     newProjectData[`v2/projects/${id}/projectTopicKey`] = newProjectTopicKey;
                 }
             });
@@ -377,16 +376,15 @@ exports.addProjectTopicKey = functions.https.onRequest(async (_, res) => {
 
 exports.addUserNameLowercase = functions.https.onRequest(async (_, res) => {
     try {
-        const userRef = admin.database().ref('v2/users');
-        const snapshot = userRef.once('value');
-        const data = (await snapshot).val();
+        const userRef = await admin.database().ref('v2/users').once('value');
+        const data = userRef.val();
 
         if (data) {
             const newUserData: {[key: string]: string} = {};
 
             Object.keys(data).forEach((id) => {
                 if (data[id]?.username) {
-                    const newUserNameKey = data[id]?.username?.toLowerCase() as string;
+                    const newUserNameKey = data[id].username?.toLowerCase() as string;
                     newUserData[`v2/users/${id}/userNameKey`] = newUserNameKey;
                 }
             });