Skip to content

Commit a4f3ae0

Browse files
committed
refac: black and flake8
1 parent 75de897 commit a4f3ae0

File tree

3 files changed

+42
-10
lines changed

3 files changed

+42
-10
lines changed

mapswipe_workers/mapswipe_workers/project_types/tile_map_service/project.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
from mapswipe_workers.utils import tile_functions, tile_grouping_functions
1717
from mapswipe_workers.utils.validate_input import (
1818
save_geojson_to_file,
19-
validate_and_collect_geometries_to_multipolyon, multipolygon_to_wkt,
19+
validate_and_collect_geometries_to_multipolyon,
20+
multipolygon_to_wkt,
2021
)
2122

2223

@@ -49,7 +50,9 @@ def __init__(self, project_draft: dict):
4950
self.tileServer = vars(BaseTileServer(project_draft["tileServer"]))
5051

5152
def validate_geometries(self):
52-
self.inputGeometriesFileName = save_geojson_to_file(self.projectId, self.geometry)
53+
self.inputGeometriesFileName = save_geojson_to_file(
54+
self.projectId, self.geometry
55+
)
5356
multi_polygon = validate_and_collect_geometries_to_multipolyon(
5457
self.projectId, self.zoomLevel, self.inputGeometriesFileName
5558
)

mapswipe_workers/mapswipe_workers/utils/validate_input.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def check_if_geom_is_valid(projectId, feat_geom):
8282
f"Probably self-intersections."
8383
)
8484

85-
raise CustomError(f"Geometry is not valid. ")
85+
raise CustomError("Geometry is not valid.")
8686

8787

8888
def check_if_project_area_is_too_big(projectId, project_area, zoomLevel):
@@ -189,15 +189,19 @@ def build_multipolygon_from_layer_geometries(projectId, layer):
189189
return multi_polygon, project_area
190190

191191

192-
def validate_and_collect_geometries_to_multipolyon(projectId, zoomLevel, input_file_path):
192+
def validate_and_collect_geometries_to_multipolyon(
193+
projectId, zoomLevel, input_file_path
194+
):
193195
"""Validate all geometries contained in input file and collect them to a single multi polygon."""
194196
layer, datasource = load_geojson_to_ogr(projectId, input_file_path)
195197

196198
# check if inputs fit constraints
197199
check_if_layer_is_empty(projectId, layer)
198200
check_if_zoom_level_is_too_high(zoomLevel)
199201

200-
multi_polygon, project_area = build_multipolygon_from_layer_geometries(projectId, layer)
202+
multi_polygon, project_area = build_multipolygon_from_layer_geometries(
203+
projectId, layer
204+
)
201205

202206
check_if_layer_has_too_many_geometries(projectId, multi_polygon)
203207
check_if_project_area_is_too_big(projectId, project_area, zoomLevel)

mapswipe_workers/tests/unittests/test_utils_validate_input.py

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
from mapswipe_workers.definitions import CustomError
88
from mapswipe_workers.utils.validate_input import (
99
save_geojson_to_file,
10-
validate_and_collect_geometries_to_multipolyon, multipolygon_to_wkt,
10+
validate_and_collect_geometries_to_multipolyon,
11+
multipolygon_to_wkt,
1112
)
1213

1314
CURRENT_DIR = os.path.dirname(os.path.abspath(__file__))
@@ -31,7 +32,13 @@ def test_area_is_too_large(self):
3132
"fixtures/tile_map_service_grid/projects/projectDraft_area_too_large.json"
3233
)
3334
project_draft, path_to_geometries = get_project_draft(path)
34-
self.assertRaises(CustomError, validate_and_collect_geometries_to_multipolyon, 1, 18, path_to_geometries)
35+
self.assertRaises(
36+
CustomError,
37+
validate_and_collect_geometries_to_multipolyon,
38+
1,
39+
18,
40+
path_to_geometries,
41+
)
3542

3643
def test_broken_geojson_string(self):
3744
"""Test if validate_geometries throws an error
@@ -42,7 +49,13 @@ def test_broken_geojson_string(self):
4249
"fixtures/tile_map_service_grid/projects/projectDraft_broken_geojson.json"
4350
)
4451
project_draft, path_to_geometries = get_project_draft(path)
45-
self.assertRaises(CustomError, validate_and_collect_geometries_to_multipolyon, 1, 18, path_to_geometries)
52+
self.assertRaises(
53+
CustomError,
54+
validate_and_collect_geometries_to_multipolyon,
55+
1,
56+
18,
57+
path_to_geometries,
58+
)
4659

4760
def test_feature_is_none(self):
4861
"""Test if validate_geometries throws an error
@@ -52,15 +65,27 @@ def test_feature_is_none(self):
5265
"fixtures/tile_map_service_grid/projects/projectDraft_feature_is_none.json"
5366
)
5467
project_draft, path_to_geometries = get_project_draft(path)
55-
self.assertRaises(CustomError, validate_and_collect_geometries_to_multipolyon, 1, 18, path_to_geometries)
68+
self.assertRaises(
69+
CustomError,
70+
validate_and_collect_geometries_to_multipolyon,
71+
1,
72+
18,
73+
path_to_geometries,
74+
)
5675

5776
def test_no_features(self):
5877
"""Test if validate_geometries throws an error
5978
if the provided geojson contains no features."""
6079

6180
path = "fixtures/tile_map_service_grid/projects/projectDraft_no_features.json"
6281
project_draft, path_to_geometries = get_project_draft(path)
63-
self.assertRaises(CustomError, validate_and_collect_geometries_to_multipolyon, 1, 18, path_to_geometries)
82+
self.assertRaises(
83+
CustomError,
84+
validate_and_collect_geometries_to_multipolyon,
85+
1,
86+
18,
87+
path_to_geometries,
88+
)
6489

6590
def test_single_geom_validation(self):
6691
path = "fixtures/completeness/projectDraft_single.json"

0 commit comments

Comments
 (0)