Skip to content

Commit b4c9017

Browse files
committed
Test fix for new groups columns
1 parent 245a613 commit b4c9017

File tree

4 files changed

+58
-21
lines changed

4 files changed

+58
-21
lines changed

mapswipe_workers/mapswipe_workers/project_types/base/project.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,15 @@ def save_to_postgres(self, project, groups, groupsOfTasks):
360360
"""
361361

362362
query_insert_raw_groups = """
363-
INSERT INTO groups
363+
INSERT INTO groups (
364+
project_id,
365+
group_id,
366+
number_of_tasks,
367+
finished_count,
368+
required_count,
369+
progress,
370+
project_type_specifics
371+
)
364372
SELECT
365373
project_id,
366374
group_id,

mapswipe_workers/tests/integration/set_up.py

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import json
1111
import os
1212
import time
13+
from typing import List, Union
1314

1415
from mapswipe_workers import auth
1516

@@ -32,7 +33,7 @@ def set_firebase_test_data(
3233

3334

3435
def set_postgres_test_data(
35-
project_type: str, data_type: str, fixture_name: str
36+
project_type: str, data_type: str, fixture_name: str, columns: Union[None, List[str]] = None
3637
) -> None:
3738
test_dir = os.path.dirname(__file__)
3839
fixture_name = fixture_name + ".csv"
@@ -41,7 +42,7 @@ def set_postgres_test_data(
4142
)
4243
pg_db = auth.postgresDB()
4344
with open(file_path) as test_file:
44-
pg_db.copy_from(test_file, data_type)
45+
pg_db.copy_from(test_file, data_type, columns=columns)
4546

4647

4748
def create_test_project(
@@ -50,9 +51,21 @@ def create_test_project(
5051
"""Create a test data in Firebase and Posgres."""
5152
project_id = "test_{0}".format(fixture_name)
5253

53-
for data_type in ["projects", "groups", "tasks"]:
54+
for data_type, columns in [
55+
("projects", None),
56+
("groups", [
57+
"project_id",
58+
"group_id",
59+
"number_of_tasks",
60+
"finished_count",
61+
"required_count",
62+
"progress",
63+
"project_type_specifics",
64+
]),
65+
("tasks", None),
66+
]:
5467
set_firebase_test_data(project_type, data_type, fixture_name, project_id)
55-
set_postgres_test_data(project_type, data_type, fixture_name)
68+
set_postgres_test_data(project_type, data_type, fixture_name, columns=columns)
5669

5770
if results:
5871
set_firebase_test_data(project_type, "users", "user", project_id)

mapswipe_workers/tests/integration/test_get_results_real_project.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,23 @@ def setUp(self):
1616
fixture_name = "build_area_sandoa"
1717
self.project_id = "-NFNr55R_LYJvxP7wmte"
1818

19-
for data_type in [
20-
"projects",
21-
"groups",
22-
"tasks",
23-
"users",
24-
"mapping_sessions",
25-
"mapping_sessions_results",
19+
for data_type, columns in [
20+
("projects", None),
21+
("groups", [
22+
"project_id",
23+
"group_id",
24+
"number_of_tasks",
25+
"finished_count",
26+
"required_count",
27+
"progress",
28+
"project_type_specifics",
29+
]),
30+
("tasks", None),
31+
("users", None),
32+
("mapping_sessions", None),
33+
("mapping_sessions_results", None),
2634
]:
27-
set_up.set_postgres_test_data(project_type, data_type, fixture_name)
35+
set_up.set_postgres_test_data(project_type, data_type, fixture_name, columns=columns)
2836

2937
self.results_filename = os.path.join(
3038
tempfile._get_default_tempdir(), f"results_{self.project_id}.csv.gz"

mapswipe_workers/tests/integration/test_user_stats.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,23 @@ def setUp(self):
2121
fixture_name = "osm_validation_malawi"
2222
self.project_id = "-NEaU7GXxWRqKaFUYp_2"
2323

24-
for data_type in [
25-
"projects",
26-
"groups",
27-
"tasks",
28-
"users",
29-
"mapping_sessions",
30-
"mapping_sessions_results",
24+
for data_type, columns in [
25+
("projects", None),
26+
("groups", [
27+
"project_id",
28+
"group_id",
29+
"number_of_tasks",
30+
"finished_count",
31+
"required_count",
32+
"progress",
33+
"project_type_specifics",
34+
]),
35+
("tasks", None),
36+
("users", None),
37+
("mapping_sessions", None),
38+
("mapping_sessions_results", None),
3139
]:
32-
set_up.set_postgres_test_data(project_type, data_type, fixture_name)
40+
set_up.set_postgres_test_data(project_type, data_type, fixture_name, columns=columns)
3341

3442
self.results_filename = os.path.join(
3543
tempfile._get_default_tempdir(), f"results_{self.project_id}.csv.gz"

0 commit comments

Comments
 (0)