Merge pull request #541 from mapswipe/hotfix-firebase-functions

Hotfix firebase functions

Author: Hagellach37

firebase/functions/index.js

@@ -44,6 +44,7 @@ exports.groupUsersCounter = functions.database.ref('/v2/results/{projectId}/{gro
     const totalGroupContributionCountRef = userRef.child('groupContributionCount')
     const userContributionRef = userRef.child('contributions/' + context.params.projectId)
     const taskContributionCountRef = userRef.child('contributions/' + context.params.projectId + '/taskContributionCount')
+    const thisResultRef = admin.database().ref('/v2/results/' + context.params.projectId + '/' + context.params.groupId + '/' + context.params.userId )
 
     // if result ref does not contain all required attributes we don't updated counters
     // e.g. due to some error when uploading from client
@@ -61,6 +62,30 @@ exports.groupUsersCounter = functions.database.ref('/v2/results/{projectId}/{gro
         return null
     }
 
+    // Check for specific user ids which have been identified as problematic.
+    // These users have repeatedly uploaded harmful results.
+    // Add new user ids to this list if needed.
+    const userIds = []
+    if ( userIds.includes(context.params.userId) ) {
+        console.log('suspicious user: ' + context.params.userId)
+        console.log('will remove this result and not update counters')
+        return Promise.all([thisResultRef.remove()])
+    }
+
+    // check if these results are likely to be vandalism
+    // mapping speed is defined by the average time needed per task in seconds
+    const numberOfTasks = Object.keys( result['results'] ).length
+    const startTime = Date.parse(result['startTime']) / 1000
+    const endTime = Date.parse(result['endTime']) / 1000
+    const mappingSpeed = (endTime - startTime) / numberOfTasks
+
+    if (mappingSpeed < 0.125) {
+        // this about 8-times faster than the average time needed per task
+        console.log('unlikely high mapping speed: ' + mappingSpeed)
+        console.log('will remove this result and not update counters')
+        return Promise.all([thisResultRef.remove()])
+    }
+
     /*
         Check if this user has submitted a results for this group already.
         If no result has been submitted yet, set userId in v2/groupsUsers.