split iconlist to instrcution icon and scenario icon list

Author: shreeyash07

manager-dashboard/app/resources/icons/tap_icon.png

@@ -33,7 +33,6 @@ import { IconType } from 'react-icons';
 import oneTapIcon from '#resources/icons/1_Tap_Black.png';
 import twoTapIcon from '#resources/icons/2_Tap_Black.png';
 import threeTapIcon from '#resources/icons/3_Tap_Black.png';
-import tapIcon from '#resources/icons/tap_icon.png';
 import angularTapIcon from '#resources/icons/tap_icon_angular.png';
 import swipeIcon from '#resources/icons/swipeleft_icon_black.png';
 
@@ -148,11 +147,6 @@ export const iconList: IconItem[] = [
         label: 'Ban',
         component: IoBanOutline,
     },
-    {
-        key: 'check',
-        label: 'Check',
-        component: IoCheckmarkOutline,
-    },
     {
         key: 'close-outline',
         label: 'Close',
@@ -263,11 +257,9 @@ export const iconList: IconItem[] = [
         label: 'Warning',
         component: IoWarningOutline,
     },
-    {
-        key: 'general-tap',
-        label: 'General Tap',
-        component: getPngIcon(tapIcon, 'general tap'),
-    },
+];
+
+const instructionsIconList: IconItem[] = [
     {
         key: 'tap',
         label: 'Tap',
@@ -293,10 +285,17 @@ export const iconList: IconItem[] = [
         label: 'Swipe Left',
         component: getPngIcon(swipeIcon, 'swipe left'),
     },
+    {
+        key: 'check',
+        label: 'Check',
+        component: IoCheckmarkOutline,
+    },
 ];
 
+export const combinedIconList = [...instructionsIconList, ...iconList];
+
 export const iconMap = listToMap(
-    iconList,
+    combinedIconList,
     (icon) => icon.key,
     (icon) => icon.component,
 );

manager-dashboard/app/utils/common.tsx

@@ -7,7 +7,7 @@ import {
     getErrorObject,
 } from '@togglecorp/toggle-form';
 import {
-    iconList,
+    combinedIconList,
     valueSelector,
     labelSelector,
     keySelector,
@@ -205,7 +205,7 @@ export default function ScenarioPageInput(props: Props) {
                         name="icon"
                         label="Icon"
                         value={value.instructions?.icon}
-                        options={iconList}
+                        options={combinedIconList}
                         keySelector={keySelector}
                         labelSelector={labelSelector}
                         onChange={handleInstructionFieldChange}
@@ -241,7 +241,7 @@ export default function ScenarioPageInput(props: Props) {
                                 name="icon"
                                 label="Icon"
                                 value={value.hint?.icon}
-                                options={iconList}
+                                options={combinedIconList}
                                 keySelector={keySelector}
                                 labelSelector={labelSelector}
                                 onChange={handleHintFieldChange}
@@ -279,7 +279,7 @@ export default function ScenarioPageInput(props: Props) {
                                 name="icon"
                                 label="Icon"
                                 value={value.success?.icon}
-                                options={iconList}
+                                options={combinedIconList}
                                 keySelector={keySelector}
                                 labelSelector={labelSelector}
                                 onChange={handleSuccessFieldChange}