Skip to content

Commit e260340

Browse files
committed
fix regex to include also project_ids starting with '-'
1 parent 7fce066 commit e260340

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

mapswipe_workers/mapswipe_workers/firebase_to_postgres/archive_project.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def archive_project(project_ids: list) -> None:
2828

2929
fb_db = auth.firebaseDB()
3030
ref = fb_db.reference(f"v2/results/{project_id}")
31-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
31+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
3232
raise CustomError(
3333
f"""Given argument resulted in invalid Firebase Realtime Database reference.
3434
{ref.path}"""
@@ -44,7 +44,7 @@ def archive_project(project_ids: list) -> None:
4444
ref.delete()
4545

4646
ref = fb_db.reference(f"v2/tasks/{project_id}")
47-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
47+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
4848
raise CustomError(
4949
f"""Given argument resulted in invalid Firebase Realtime Database reference.
5050
{ref.path}"""
@@ -60,15 +60,15 @@ def archive_project(project_ids: list) -> None:
6060
ref.delete()
6161

6262
ref = fb_db.reference(f"v2/groups/{project_id}")
63-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
63+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
6464
raise CustomError(
6565
f"""Given argument resulted in invalid Firebase Realtime Database reference.
6666
{ref.path}"""
6767
)
6868
ref.delete()
6969

7070
ref = fb_db.reference(f"v2/groups/{project_id}")
71-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
71+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
7272
raise CustomError(
7373
f"""Given argument resulted in invalid Firebase Realtime Database reference.
7474
{ref.path}"""

mapswipe_workers/mapswipe_workers/firebase_to_postgres/delete_project.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def delete_project(project_ids: list) -> None:
2727

2828
fb_db = auth.firebaseDB()
2929
ref = fb_db.reference(f"v2/results/{project_id}")
30-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
30+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
3131
raise CustomError(
3232
f"""Given argument resulted in invalid Firebase Realtime Database reference.
3333
{ref.path}"""
@@ -43,7 +43,7 @@ def delete_project(project_ids: list) -> None:
4343
ref.delete()
4444

4545
ref = fb_db.reference(f"v2/tasks/{project_id}")
46-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
46+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
4747
raise CustomError(
4848
f"""Given argument resulted in invalid Firebase Realtime Database reference.
4949
{ref.path}"""
@@ -59,14 +59,14 @@ def delete_project(project_ids: list) -> None:
5959
ref.delete()
6060

6161
ref = fb_db.reference(f"v2/groups/{project_id}")
62-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
62+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
6363
raise CustomError(
6464
f"""Given argument resulted in invalid Firebase Realtime Database reference.
6565
{ref.path}"""
6666
)
6767
ref.delete()
6868
ref = fb_db.reference(f"v2/projects/{project_id}")
69-
if not re.match(r"/v2/\w+/[a-zA-Z0-9|-|_]+", ref.path):
69+
if not re.match(r"/v2/\w+/[-a-zA-Z0-9]+", ref.path):
7070
raise CustomError(
7171
f"""Given argument resulted in invalid Firebase Realtime Database reference.
7272
{ref.path}"""

0 commit comments

Comments
 (0)