feat: add size restriction for too many images

Author: Gigaszi

mapswipe_workers/mapswipe_workers/utils/process_mapillary.py

@@ -208,7 +208,6 @@ def filter_results(
             return None
         df = filter_by_timerange(df, start_time, end_time)
 
-
     return df
 
 
@@ -235,10 +234,15 @@ def get_image_metadata(
     )
     if sampling_threshold is not None:
         downloaded_metadata = spatial_sampling(downloaded_metadata, sampling_threshold)
-    if downloaded_metadata.isna().all().all() == False:
-        return {
-            "ids": downloaded_metadata["id"].tolist(),
-            "geometries": downloaded_metadata["geometry"].tolist(),
-        }
+    if downloaded_metadata.isna().all().all() == False or downloaded_metadata.empty == False:
+        if len(downloaded_metadata) > 100000:
+            err = (f"Too many Images with selected filter "
+                   f"options for the AoI: {len(downloaded_metadata)}")
+            raise ValueError(err)
+        else:
+            return {
+                "ids": downloaded_metadata["id"].tolist(),
+                "geometries": downloaded_metadata["geometry"].tolist(),
+            }
     else:
         raise ValueError("No Mapillary Features in the AoI match the filter criteria.")

mapswipe_workers/tests/unittests/test_process_mapillary.py

@@ -328,6 +328,30 @@ def test_get_image_metadata_no_rows(self, mock_coordinate_download):
         with self.assertRaises(ValueError):
             get_image_metadata(self.fixture_data, **params)
 
+    @patch("mapswipe_workers.utils.process_mapillary.coordinate_download")
+    def test_get_image_metadata_empty_response(self, mock_coordinate_download):
+        df = self.fixture_df.copy()
+        df = df.drop(df.index)
+        mock_coordinate_download.return_value = (
+            df,
+            None
+        )
+
+        with self.assertRaises(ValueError):
+            get_image_metadata(self.fixture_data)
+
+    @patch("mapswipe_workers.utils.process_mapillary.filter_results")
+    @patch("mapswipe_workers.utils.process_mapillary.coordinate_download")
+    def test_get_image_metadata_size_restriction(self, mock_coordinate_download, mock_filter_results):
+        mock_filter_results.return_value = pd.DataFrame({'ID': range(1, 100002)})
+        mock_coordinate_download.return_value = (
+            self.fixture_df,
+            None,
+        )
+
+        with self.assertRaises(ValueError):
+            get_image_metadata(self.fixture_data)
+
 
 if __name__ == "__main__":
     unittest.main()