NEEDS-DISCUSSION: Highlight code references on navigation #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @Ardeshir81 , Sorry for the delay getting to this. How do you feel about this feature after a couple of months delay? Have you been using it? |
Author
|
Hi @maptz . Its nice to know that you are Alive! 😃 I just re-checked it and the issue still is there. (Using VS-Code Insiders 1.55) Have a nice life :) |
Author
|
Hey @maptz I just rechecked it. I still agree with this PR:
however:
I still believe merging this PR is a step forward, however is not best solution possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI! I already have filed an issue: #23
Now I came to add a workaround to it. My idea was to trigger a
cursorLeftandcursorRightafter each camelCase navigation. (So that cursor is at the right place, but also native vscode highlighting occurs).Later I found that there is a specific command for this task:
editor.action.wordHighlight.triggerUnfortunately both this methods do not act exactly like vscode's native highlighting. There is a little sometimes annoying delay between highlights. In below GIF I demo both the native and this PR's highlihgting in action:
Now I doubt if this is good at all, or lack of this feature is better than having this version at all.
Another method that I think would be nice, is that this extension just calculates the amount of cursor moves that need to be applied, and then call
cursorLeftandcursorRightcorresponding multiple times. I try to see if I can work on that. (and also try to check if that does not cause performance issues)