#30 - Once loading is in progress, it just wails util it finishes (instead of starting a new one).

Author: maraf

src/GitExtensions.BundleBackuper/UI/BundleListMenuItem.cs

@@ -5,6 +5,7 @@
 using System.IO;
 using System.Linq;
 using System.Text;
+using System.Threading;
 using System.Threading.Tasks;
 using System.Windows.Forms;
 
@@ -17,6 +18,7 @@ public class BundleListMenuItem : ToolStripMenuItem
     {
         private readonly IBundleProvider provider;
         private readonly IGitBundleMapper mapper;
+        private bool isLoading;
 
         internal BundleListMenuItem(IBundleProvider provider, IGitBundleMapper mapper, IGitBundleFactory bundleFactory, PluginSettings settings)
         {
@@ -34,31 +36,43 @@ internal BundleListMenuItem(IBundleProvider provider, IGitBundleMapper mapper, I
 
         private async void OnDropDownOpening(object sender, EventArgs e)
         {
-            foreach (var item in DropDown.Items.OfType<BundleMapMenuItem>().ToList())
-                DropDown.Items.Remove(item);
+            if (isLoading)
+                return;
 
-            NoDataMenuItem noData = DropDown.Items.OfType<NoDataMenuItem>().FirstOrDefault();
-            if (noData != null)
-                DropDown.Items.Remove(noData);
+            try
+            {
+                isLoading = true;
 
-            if (DropDown.Items.Count == 3)
-                DropDown.Items.RemoveAt(2);
+                foreach (var item in DropDown.Items.OfType<BundleMapMenuItem>().ToList())
+                    DropDown.Items.Remove(item);
 
-            DropDown.Items.Add(new ToolStripSeparator());
-            int loadingIndex = DropDown.Items.Add(new LoadingMenuItem());
+                NoDataMenuItem noData = DropDown.Items.OfType<NoDataMenuItem>().FirstOrDefault();
+                if (noData != null)
+                    DropDown.Items.Remove(noData);
 
-            if (!await provider.IsAvailableAsync())
-            {
-                DropDown.Items.RemoveAt(2);
-                DropDown.Items.RemoveAt(2);
-                SetItemsEnabled(false);
-                return;
-            }
+                if (DropDown.Items.Count == 3)
+                    DropDown.Items.RemoveAt(2);
 
-            SetItemsEnabled(true);
-            DropDown.Items.AddRange(await CreateBundleItemsAsync());
+                DropDown.Items.Add(new ToolStripSeparator());
+                int loadingIndex = DropDown.Items.Add(new LoadingMenuItem());
 
-            DropDown.Items.RemoveAt(loadingIndex);
+                if (!await provider.IsAvailableAsync())
+                {
+                    DropDown.Items.RemoveAt(2);
+                    DropDown.Items.RemoveAt(2);
+                    SetItemsEnabled(false);
+                    return;
+                }
+
+                SetItemsEnabled(true);
+                DropDown.Items.AddRange(await CreateBundleItemsAsync());
+
+                DropDown.Items.RemoveAt(loadingIndex);
+            }
+            finally
+            {
+                isLoading = false;
+            }
         }
 
         private async Task<ToolStripItem[]> CreateBundleItemsAsync()