#33 - Rewrite background git process execution.

Author: maraf

src/GitExtensions.BundleBackuper/Services/GitUiCommandsBundleService.cs

@@ -151,7 +151,7 @@ private string FindCommitIdIfPushed(IGitUICommands commands, string head, int he
 
         private string FindCommitId(IGitUICommands commands, string head, int headOffset)
         {
-            string commitId = commands.GitModule.RunGitCmd($"rev-parse {head}~{headOffset}").Trim();
+            string commitId = RunGitCommand(commands, $"rev-parse {head}~{headOffset}").Trim();
             if (!String.IsNullOrWhiteSpace(commitId) && !commitId.Contains(" "))
                 return commitId;
 
@@ -164,7 +164,9 @@ private bool IsCommitPushed(IGitUICommands commands, string head, int headOffset
             if (String.IsNullOrEmpty(commitId))
                 return true;
 
-            string branches = commands.GitModule.RunGitCmd($"branch -r --contains {commitId}");
+            
+
+            string branches = RunGitCommand(commands, $"branch -r --contains {commitId}");
             if (String.IsNullOrWhiteSpace(branches))
                 return false;
 
@@ -211,5 +213,19 @@ private int BinarySearch(int start, int end, Func<int, int> predicate)
                     throw Ensure.Exception.NotSupported("BinarySearch predicate must return -1, 0 or 1.");
             }
         }
+
+        private string RunGitCommand(IGitUICommands commands, string arguments)
+        {
+            using (IProcess process = commands.GitModule.GitCommandRunner.RunDetached(arguments, redirectOutput: true))
+            {
+                process.WaitForExit();
+
+                string error = process.StandardError.ReadToEnd();
+                if (!String.IsNullOrEmpty(error))
+                    return error;
+
+                return process.StandardOutput.ReadToEnd();
+            }
+        }
     }
 }