Skip to content

Commit a00b4d7

Browse files
committed
Drop nanobind workaround
This drops the workaround to set linker flags to work around the issue when building the compiler Python bindings for macOS as this is fixed upstream as soon as llvm/llvm-project#125733 lands and was integrated into IREE's llvm fork. Closes iree-org#19591
1 parent 56bb652 commit a00b4d7

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -649,11 +649,6 @@ if(IREE_BUILD_PYTHON_BINDINGS)
649649
# can be troublesome. Note that nanobind requires FindPython.
650650
set(Python_EXECUTABLE "${Python3_EXECUTABLE}")
651651
find_package(Python 3.9 COMPONENTS Interpreter Development.Module NumPy REQUIRED)
652-
if(APPLE)
653-
# Workaround for upstream using PyClassMethod_New but nanobind not being aware
654-
# see https://github.com/iree-org/iree/issues/19591
655-
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-U -Wl,_PyClassMethod_New")
656-
endif()
657652
elseif(IREE_BUILD_COMPILER OR IREE_BUILD_TESTS)
658653
find_package(Python3 COMPONENTS Interpreter REQUIRED)
659654
set(Python_EXECUTABLE "${Python3_EXECUTABLE}")

0 commit comments

Comments
 (0)