tests: use of magic constant '::class'

Author: marc-mabe

tests/MabeEnumTest/EnumMapTest.php

@@ -2,6 +2,7 @@
 
 namespace MabeEnumTest;
 
+use InvalidArgumentException;
 use MabeEnum\EnumMap;
 use MabeEnumTest\TestAsset\EnumBasic;
 use MabeEnumTest\TestAsset\EnumInheritance;
@@ -19,8 +20,8 @@ class EnumMapTest extends TestCase
 {
     public function testBasic()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
-        $this->assertSame('MabeEnumTest\TestAsset\EnumBasic', $enumMap->getEnumeration());
+        $enumMap = new EnumMap(EnumBasic::class);
+        $this->assertSame(EnumBasic::class, $enumMap->getEnumeration());
 
         $enum1  = EnumBasic::ONE();
         $value1 = 'value1';
@@ -49,7 +50,7 @@ public function testBasic()
 
     public function testBasicWithConstantValuesAsEnums()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
         $enum1  = EnumBasic::ONE;
         $value1 = 'value1';
@@ -78,7 +79,7 @@ public function testBasicWithConstantValuesAsEnums()
 
     public function testIterate()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
         $enum1  = EnumBasic::ONE();
         $value1 = 'value1';
@@ -122,7 +123,7 @@ public function testIterate()
 
     public function testArrayAccessWithObjects()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
         $enumMap[EnumBasic::ONE()] = 'first';
         $enumMap[EnumBasic::TWO()] = 'second';
@@ -141,7 +142,7 @@ public function testArrayAccessWithObjects()
 
     public function testArrayAccessWithValues()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
         $enumMap[EnumBasic::ONE] = 'first';
         $enumMap[EnumBasic::TWO] = 'second';
@@ -160,21 +161,21 @@ public function testArrayAccessWithValues()
 
     public function testConstructThrowsInvalidArgumentExceptionIfEnumClassDoesNotExtendBaseEnum()
     {
-        $this->setExpectedException('InvalidArgumentException');
+        $this->setExpectedException(InvalidArgumentException::class);
         new EnumMap('stdClass');
     }
 
     public function testInitEnumThrowsInvalidArgumentExceptionOnInvalidEnumGiven()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
-        $this->setExpectedException('InvalidArgumentException');
+        $this->setExpectedException(InvalidArgumentException::class);
         $enumMap->offsetSet(EnumInheritance::INHERITANCE(), 'test');
     }
 
     public function testContainsAndOffsetExistsReturnsFalseOnInvalidEnum()
     {
-        $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic');
+        $enumMap = new EnumMap(EnumBasic::class);
 
         $this->assertFalse($enumMap->contains(EnumInheritance::INHERITANCE()));
         $this->assertFalse($enumMap->contains(EnumInheritance::INHERITANCE));

tests/MabeEnumTest/EnumSerializableTraitTest.php

@@ -2,9 +2,12 @@
 
 namespace MabeEnumTest;
 
+use LogicException;
+use MabeEnum\Enum;
 use MabeEnumTest\TestAsset\SerializableEnum;
 use PHPUnit_Framework_TestCase as TestCase;
 use ReflectionClass;
+use RuntimeException;
 
 /**
  * Unit tests for the trait MabeEnum\EnumSerializableTrait
@@ -15,20 +18,13 @@
  */
 class EnumSerializableTraitTest extends TestCase
 {
-    public function setUp()
-    {
-        if (PHP_VERSION_ID < 50400) {
-            $this->markTestSkipped('Traits require PHP-5.4');
-        }
-    }
-
     public function testSerializeSerializableEnum()
     {
         $serialized = serialize(SerializableEnum::get(SerializableEnum::NIL));
         $this->assertInternalType('string', $serialized);
 
         $unserialized = unserialize($serialized);
-        $this->assertInstanceOf('MabeEnumTest\TestAsset\SerializableEnum', $unserialized);
+        $this->assertInstanceOf(SerializableEnum::class, $unserialized);
     }
 
     public function testUnserializeFirstWillHoldTheSameInstance()
@@ -37,11 +33,11 @@ public function testUnserializeFirstWillHoldTheSameInstance()
         $this->assertInternalType('string', $serialized);
 
         // clear all instantiated instances so we can virtual test unserializing first
-        $this->clearEnumeration('MabeEnumTest\TestAsset\SerializableEnum');
+        $this->clearEnumeration(SerializableEnum::class);
 
         // First unserialize
         $unserialized = unserialize($serialized);
-        $this->assertInstanceOf('MabeEnumTest\TestAsset\SerializableEnum', $unserialized);
+        $this->assertInstanceOf(SerializableEnum::class, $unserialized);
 
         // second instantiate
         $enum = SerializableEnum::get($unserialized->getValue());
@@ -52,19 +48,19 @@ public function testUnserializeFirstWillHoldTheSameInstance()
 
     public function testUnserializeThrowsRuntimeExceptionOnUnknownValue()
     {
-        $this->setExpectedException('RuntimeException');
-        unserialize('C:39:"MabeEnumTest\TestAsset\SerializableEnum":11:{s:4:"test";}');
+        $this->setExpectedException(RuntimeException::class);
+        unserialize('C:' . strlen(SerializableEnum::class) . ':"' . SerializableEnum::class . '":11:{s:4:"test";}');
     }
 
     public function testUnserializeThrowsRuntimeExceptionOnInvalidValue()
     {
-        $this->setExpectedException('RuntimeException');
-        unserialize('C:39:"MabeEnumTest\TestAsset\SerializableEnum":19:{O:8:"stdClass":0:{}}');
+        $this->setExpectedException(RuntimeException::class);
+        unserialize('C:' . strlen(SerializableEnum::class) . ':"' . SerializableEnum::class . '":19:{O:8:"stdClass":0:{}}');
     }
 
     public function testUnserializeThrowsLogicExceptionOnChangingValue()
     {
-        $this->setExpectedException('LogicException');
+        $this->setExpectedException(LogicException::class);
         $enum = SerializableEnum::get(SerializableEnum::INT);
         $enum->unserialize(serialize(SerializableEnum::STR));
     }
@@ -76,7 +72,7 @@ public function testUnserializeThrowsLogicExceptionOnChangingValue()
     private function clearEnumeration($enumeration)
     {
         $reflClass = new ReflectionClass($enumeration);
-        while ($reflClass->getName() !== 'MabeEnum\Enum') {
+        while ($reflClass->getName() !== Enum::class) {
             $reflClass = $reflClass->getParentClass();
         }