Use static keyword instead of get_called_class() for performance reason

marc-mabe · marc-mabe · commit 65bf4ac34d1e · 2014-09-09T10:13:58.000+02:00
diff --git a/src/MabeEnum/Enum.php b/src/MabeEnum/Enum.php
@@ -147,7 +147,7 @@ final public function is($enum)
     final public static function get($value, $tradeExtendedAsUnknown = true)
     {
         if ($value instanceof static) {
-            if ($tradeExtendedAsUnknown && !defined(get_called_class() . '::' . $value->getName())) {
+            if ($tradeExtendedAsUnknown && !defined('static::' . $value->getName())) {
                 throw new InvalidArgumentException(sprintf(
                     "%s::%s is not inherited from %s",
                     get_class($value),

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ final public function is($enum)`
`147`	`147`	`final public static function get($value, $tradeExtendedAsUnknown = true)`
`148`	`148`	`{`
`149`	`149`	`if ($value instanceof static) {`
`150`		`- if ($tradeExtendedAsUnknown && !defined(get_called_class() . '::' . $value->getName())) {`
	`150`	`+ if ($tradeExtendedAsUnknown && !defined('static::' . $value->getName())) {`
`151`	`151`	`throw new InvalidArgumentException(sprintf(`
`152`	`152`	`"%s::%s is not inherited from %s",`
`153`	`153`	`get_class($value),`