Merge pull request #13 from marc-mabe/unique

LogicException on ambiguous values

Author: Marc Bennewitz

src/MabeEnum/Enum.php

@@ -38,14 +38,27 @@ public function __construct($value)
         $reflectionClass = new ReflectionClass($this);
         $constants       = $reflectionClass->getConstants();
 
+        // Constant values needs to be unique
+        if (count($constants) > count(array_unique($constants))) {
+            $ambiguous = array();
+            foreach (array_count_values($constants) as $constValue => $countValue) {
+                if ($countValue < 2) {
+                    continue;
+                }
+                $ambiguous[] = $constValue;
+            }
+            throw new LogicException(sprintf(
+                'All possible values needs to be unique. The following are ambiguous: %s',
+                "'" . implode("', '", $ambiguous) . "'"
+            ));
+        }
+
         // This is required to make sure that constants of base classes will be the first
         while ( ($reflectionClass = $reflectionClass->getParentClass()) ) {
             $constants = $reflectionClass->getConstants() + $constants;
         }
         $this->constants = $constants;
 
-        // TODO: Check that constant values are equal (non strict comparison)
-
         // find and set the given value
         // set the defined value because of non strict comparison
         $const = array_search($value, $this->constants);

tests/MabeEnumTest/EnumTest.php

@@ -103,4 +103,10 @@ public function testInstantiateUsingMagicMethodThrowsBadMethodCallException()
         $this->setExpectedException('BadMethodCallException');
         MabeEnumTest_TestAsset_EnumInheritance::UNKNOWN();
     }
+
+    public function testAmbuguousConstantsThrowsLogicException()
+    {
+        $this->setExpectedException('LogicException');
+        new MabeEnumTest_TestAsset_EnumAmbiguous(MabeEnumTest_TestAsset_EnumAmbiguous::AMBIGUOUS1);
+    }
 }

tests/MabeEnumTest/TestAsset/EnumAmbiguous.php

@@ -0,0 +1,17 @@
+<?php
+
+/**
+ * Unit tests for the class MabeEnum_Enum
+ *
+ * @link http://github.com/marc-mabe/php-enum for the canonical source repository
+ * @copyright Copyright (c) 2012 Marc Bennewitz
+ * @license http://github.com/marc-mabe/php-enum/blob/master/LICENSE.txt New BSD License
+ */
+class MabeEnumTest_TestAsset_EnumAmbiguous extends MabeEnum_Enum
+{
+    const UNIQUE1    = 'unique1';
+    const AMBIGUOUS1 = 1;
+    const UNIQUE2    = 'unique2';
+    const AMBIGUOUS2 = '1';
+    const UNIQUE3    = 'unique3';
+}