private methods are already final by definition

marc-mabe · marc-mabe · commit 93088236d143 · 2013-10-03T09:03:17.000+02:00
diff --git a/src/MabeEnum/Enum.php b/src/MabeEnum/Enum.php
@@ -47,7 +47,7 @@ abstract class Enum
      * @throws InvalidArgumentException On an unknwon or invalid value
      * @throws LogicException           On ambiguous constant values
      */
-    final private function __construct($value, $ordinal = null)
+    private function __construct($value, $ordinal = null)
     {
         $this->value   = $value;
         $this->ordinal = $ordinal;
@@ -67,7 +67,7 @@ final public function __toString()
      * @throws LogicException Enums are not cloneable
      *                        because instances are implemented as singletons
      */
-    final private function __clone()
+    private function __clone()
     {
         throw new LogicException('Enums are not cloneable');
     }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ abstract class Enum`
`47`	`47`	`* @throws InvalidArgumentException On an unknwon or invalid value`
`48`	`48`	`* @throws LogicException On ambiguous constant values`
`49`	`49`	`*/`
`50`		`- final private function __construct($value, $ordinal = null)`
	`50`	`+ private function __construct($value, $ordinal = null)`
`51`	`51`	`{`
`52`	`52`	`$this->value = $value;`
`53`	`53`	`$this->ordinal = $ordinal;`
`@@ -67,7 +67,7 @@ final public function __toString()`
`67`	`67`	`* @throws LogicException Enums are not cloneable`
`68`	`68`	`* because instances are implemented as singletons`
`69`	`69`	`*/`
`70`		`- final private function __clone()`
	`70`	`+ private function __clone()`
`71`	`71`	`{`
`72`	`72`	`throw new LogicException('Enums are not cloneable');`
`73`	`73`	`}`