coding style fixes

Author: marc-mabe

src/Enum.php

@@ -222,7 +222,7 @@ final public static function getByOrdinal($ordinal)
         $class     = get_called_class();
         $constants = self::detectConstants($class);
         $item      = array_slice($constants, $ordinal, 1, true);
-        if (!$item) {
+        if (empty($item)) {
             throw new InvalidArgumentException(sprintf(
                 'Invalid ordinal number, must between 0 and %s',
                 count($constants) - 1
@@ -292,7 +292,7 @@ private static function detectConstants($class)
                     $ambiguous[var_export($value, true)] = $names;
                 }
             }
-            if ($ambiguous) {
+            if (!empty($ambiguous)) {
                 throw new LogicException(
                     'All possible values needs to be unique. The following are ambiguous: '
                     . implode(', ', array_map(function ($names) use ($constants) {

tests/MabeEnumTest/EnumTest.php

@@ -111,9 +111,10 @@ public function testGetEnumerators()
     {
         $constants   = EnumInheritance::getConstants();
         $enumerators = EnumInheritance::getEnumerators();
+        $count       = count($enumerators);
 
-        $this->assertSame(count($constants), count($enumerators));
-        for ($i = 0; $i < count($enumerators); ++$i) {
+        $this->assertSame(count($constants), $count);
+        for ($i = 0; $i < $count; ++$i) {
             $this->assertArrayHasKey($i, $enumerators);
             $this->assertInstanceOf('MabeEnumTest\TestAsset\EnumInheritance', $enumerators[$i]);