deprecated Enum::clear()

This static method was only for testing and on the same time it broke singleton behavior is used somewhere else as in this library tests. This removed all unnecessary usagas of it and rewrote necessary usages with reflection. So this cind of internal method is no longer needed and can be removed.

Author: marc-mabe

src/Enum.php

@@ -239,6 +239,7 @@ final public static function getByOrdinal($ordinal)
      * NOTE: This can break singleton behavior ... use it with caution!
      *
      * @return void
+     * @deprecated
      */
     final public static function clear()
     {

tests/MabeEnumTest/EnumSerializableTraitTest.php

@@ -4,6 +4,7 @@
 
 use MabeEnumTest\TestAsset\SerializableEnum;
 use PHPUnit_Framework_TestCase as TestCase;
+use ReflectionClass;
 
 /**
  * Unit tests for the trait MabeEnum\EnumSerializableTrait
@@ -16,11 +17,9 @@ class EnumSerializableTraitTest extends TestCase
 {
     public function setUp()
     {
-        if (version_compare(PHP_VERSION, '5.4', '<')) {
+        if (PHP_VERSION_ID < 50400) {
             $this->markTestSkipped('Traits require PHP-5.4');
         }
-
-        SerializableEnum::clear();
     }
 
     public function testSerializeSerializableEnum()
@@ -38,7 +37,7 @@ public function testUnserializeFirstWillHoldTheSameInstance()
         $this->assertInternalType('string', $serialized);
 
         // clear all instantiated instances so we can virtual test unserializing first
-        SerializableEnum::clear();
+        $this->clearEnumeration('MabeEnumTest\TestAsset\SerializableEnum');
 
         // First unserialize
         $unserialized = unserialize($serialized);
@@ -69,4 +68,23 @@ public function testUnserializeThrowsLogicExceptionOnChangingValue()
         $enum = SerializableEnum::get(SerializableEnum::INT);
         $enum->unserialize(serialize(SerializableEnum::STR));
     }
+
+    /**
+     * Clears all instantiated enumerations and detected constants of the given enumerator
+     * @param string $enumeration
+     */
+    private function clearEnumeration($enumeration)
+    {
+        $reflClass = new ReflectionClass($enumeration);
+        while ($reflClass->getName() !== 'MabeEnum\Enum') {
+            $reflClass = $reflClass->getParentClass();
+        }
+
+        $reflPropInstances = $reflClass->getProperty('instances');
+        $reflPropInstances->setAccessible(true);
+        $reflPropInstances->setValue(null, array());
+        $reflPropConstants = $reflClass->getProperty('constants');
+        $reflPropConstants->setAccessible(true);
+        $reflPropConstants->setValue(null, array());
+    }
 }

tests/MabeEnumTest/EnumTest.php

@@ -20,12 +20,6 @@
  */
 class EnumTest extends TestCase
 {
-    public function setUp()
-    {
-        EnumBasic::clear();
-        EnumInheritance::clear();
-    }
-
     public function testGetNameReturnsConstantNameOfCurrentValue()
     {
         $enum = EnumBasic::get(EnumBasic::ONE);