optimized ordinal handling of Enum::getName()

marc-mabe · marc-mabe · commit fc93d58bd81a · 2017-10-03T07:55:55.000+02:00
diff --git a/src/Enum.php b/src/Enum.php
@@ -117,10 +117,8 @@ final public function getValue()
      */
     final public function getName()
     {
-        if ($this->ordinal !== null) {
-            return self::$names[static::class][$this->ordinal];
-        }
-        return \array_search($this->value, self::detectConstants(static::class), true);
+        $ordinal = $this->ordinal !== null ? $this->ordinal : $this->getOrdinal();
+        return self::$names[static::class][$ordinal];
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -117,10 +117,8 @@ final public function getValue()`
`117`	`117`	`*/`
`118`	`118`	`final public function getName()`
`119`	`119`	`{`
`120`		`- if ($this->ordinal !== null) {`
`121`		`- return self::$names[static::class][$this->ordinal];`
`122`		`- }`
`123`		`- return \array_search($this->value, self::detectConstants(static::class), true);`
	`120`	`+ $ordinal = $this->ordinal !== null ? $this->ordinal : $this->getOrdinal();`
	`121`	`+ return self::$names[static::class][$ordinal];`
`124`	`122`	`}`
`125`	`123`
`126`	`124`	`/**`