[CodeHealth] Fix clang-tidy warnings part 1 (open-telemetry#3493)

Author: dbarker

.github/workflows/clang-tidy.yaml

@@ -17,9 +17,9 @@ jobs:
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 215
+            warning_limit: 172
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 216
+            warning_limit: 173
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@002fdce3c6a235733a90a27c80493a3241e56863 # v2.12.1

CHANGELOG.md

@@ -30,6 +30,9 @@ Increment the:
 * [REMOVAL] Removed deprecated semantic convention header files
   [#3475](https://github.com/open-telemetry/opentelemetry-cpp/pull/3475)
 
+* [CodeHealth] Fix clang-tidy warnings part 1
+  [#3493](https://github.com/open-telemetry/opentelemetry-cpp/pull/3493)
+
 Important changes:
 
 * [REMOVAL] Removed deprecated semantic convention header files

examples/otlp/grpc_metric_main.cc

@@ -117,10 +117,10 @@ int main(int argc, char *argv[])
       }
     }
   }
-  std::cout << "Using endpoint: " << exporter_options.endpoint << std::endl;
-  std::cout << "Using example type: " << example_type << std::endl;
-  std::cout << "Using cacert path: " << exporter_options.ssl_credentials_cacert_path << std::endl;
-  std::cout << "Using ssl credentials: " << exporter_options.use_ssl_credentials << std::endl;
+  std::cout << "Using endpoint: " << exporter_options.endpoint << "\n";
+  std::cout << "Using example type: " << example_type << "\n";
+  std::cout << "Using cacert path: " << exporter_options.ssl_credentials_cacert_path << "\n";
+  std::cout << "Using ssl credentials: " << exporter_options.use_ssl_credentials << "\n";
 
   // Removing this line will leave the default noop MetricProvider in place.
 

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_client.h

@@ -81,9 +81,9 @@ class OtlpFileClient
   bool is_shutdown_;
 
   // The configuration options associated with this file client.
-  const OtlpFileClientOptions options_;
+  OtlpFileClientOptions options_;
   // The runtime options associated with this file client.
-  const OtlpFileClientRuntimeOptions runtime_options_;
+  OtlpFileClientRuntimeOptions runtime_options_;
 
   opentelemetry::nostd::shared_ptr<OtlpFileAppender> backend_;
 };

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_file_client_runtime_options.h

@@ -19,9 +19,6 @@ namespace otlp
  */
 struct OtlpFileClientRuntimeOptions
 {
-  OtlpFileClientRuntimeOptions()  = default;
-  ~OtlpFileClientRuntimeOptions() = default;
-
   std::shared_ptr<sdk::common::ThreadInstrumentation> thread_instrumentation =
       std::shared_ptr<sdk::common::ThreadInstrumentation>(nullptr);
 };

exporters/otlp/src/otlp_file_client.cc

@@ -719,11 +719,11 @@ static inline char HexEncode(unsigned char byte)
 #endif
   if (byte >= 10)
   {
-    return byte - 10 + 'a';
+    return static_cast<char>(byte - 10 + 'a');
   }
   else
   {
-    return byte + '0';
+    return static_cast<char>(byte + '0');
   }
 }
 
@@ -1004,6 +1004,11 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpFileSystemBackend : public OtlpFileAppender
     }
   }
 
+  OtlpFileSystemBackend(const OtlpFileSystemBackend &)            = delete;
+  OtlpFileSystemBackend &operator=(const OtlpFileSystemBackend &) = delete;
+  OtlpFileSystemBackend(OtlpFileSystemBackend &&)                 = delete;
+  OtlpFileSystemBackend &operator=(OtlpFileSystemBackend &&)      = delete;
+
   // Written size is not required to be precise, we can just ignore tsan report here.
   OPENTELEMETRY_SANITIZER_NO_THREAD void MaybeRotateLog(std::size_t data_size)
   {
@@ -1588,11 +1593,9 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpFileOstreamBackend : public OtlpFileAppende
 public:
   explicit OtlpFileOstreamBackend(const std::reference_wrapper<std::ostream> &os) : os_(os) {}
 
-  ~OtlpFileOstreamBackend() override {}
-
   void Export(nostd::string_view data, std::size_t /*record_count*/) override
   {
-    os_.get().write(data.data(), data.size());
+    os_.get().write(data.data(), static_cast<std::streamsize>(data.size()));
   }
 
   bool ForceFlush(std::chrono::microseconds /*timeout*/) noexcept override
@@ -1611,8 +1614,8 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpFileOstreamBackend : public OtlpFileAppende
 OtlpFileClient::OtlpFileClient(OtlpFileClientOptions &&options,
                                OtlpFileClientRuntimeOptions &&runtime_options)
     : is_shutdown_(false),
-      options_(std::move(options)),
-      runtime_options_(std::move(runtime_options))
+      options_{std::move(options)},
+      runtime_options_{std::move(runtime_options)}
 {
   if (nostd::holds_alternative<OtlpFileClientFileSystemOptions>(options_.backend_options))
   {

exporters/otlp/src/otlp_http_client.cc

@@ -175,7 +175,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: session create failed.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -207,7 +207,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: connection failed.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -232,7 +232,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: request send failed.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -250,7 +250,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: SSL handshake failed.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -261,7 +261,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: request time out.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -272,7 +272,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: network error.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -297,7 +297,7 @@ class ResponseHandler : public http_client::EventHandler
         error_message << "[OTLP HTTP Client] Session state: (manually) cancelled.";
         if (!reason.empty())
         {
-          error_message.write(reason.data(), reason.size());
+          error_message.write(reason.data(), static_cast<std::streamsize>(reason.size()));
         }
         OTEL_INTERNAL_LOG_ERROR(error_message.str());
       }
@@ -376,11 +376,11 @@ static inline char HexEncode(unsigned char byte)
 #endif
   if (byte >= 10)
   {
-    return byte - 10 + 'a';
+    return static_cast<char>(byte - 10 + 'a');
   }
   else
   {
-    return byte + '0';
+    return static_cast<char>(byte + '0');
   }
 }
 
@@ -664,7 +664,7 @@ void ConvertListFieldToJson(nlohmann::json &value,
 
 OtlpHttpClient::OtlpHttpClient(OtlpHttpClientOptions &&options)
     : is_shutdown_(false),
-      options_(options),
+      options_(std::move(options)),
       http_client_(http_client::HttpClientFactory::Create(options.thread_instrumentation)),
       start_session_counter_(0),
       finished_session_counter_(0)

sdk/include/opentelemetry/sdk/metrics/aggregation/lastvalue_aggregation.h

@@ -21,7 +21,6 @@ class LongLastValueAggregation : public Aggregation
 {
 public:
   LongLastValueAggregation();
-  LongLastValueAggregation(LastValuePointData &&);
   LongLastValueAggregation(const LastValuePointData &);
 
   void Aggregate(int64_t value, const PointAttributes &attributes = {}) noexcept override;
@@ -43,16 +42,15 @@ class DoubleLastValueAggregation : public Aggregation
 {
 public:
   DoubleLastValueAggregation();
-  DoubleLastValueAggregation(LastValuePointData &&);
   DoubleLastValueAggregation(const LastValuePointData &);
 
   void Aggregate(int64_t /* value */, const PointAttributes & /* attributes */) noexcept override {}
 
   void Aggregate(double value, const PointAttributes &attributes = {}) noexcept override;
 
-  virtual std::unique_ptr<Aggregation> Merge(const Aggregation &delta) const noexcept override;
+  std::unique_ptr<Aggregation> Merge(const Aggregation &delta) const noexcept override;
 
-  virtual std::unique_ptr<Aggregation> Diff(const Aggregation &next) const noexcept override;
+  std::unique_ptr<Aggregation> Diff(const Aggregation &next) const noexcept override;
 
   PointType ToPoint() const noexcept override;
 

sdk/include/opentelemetry/sdk/metrics/aggregation/sum_aggregation.h

@@ -22,7 +22,6 @@ class LongSumAggregation : public Aggregation
 {
 public:
   LongSumAggregation(bool is_monotonic);
-  LongSumAggregation(SumPointData &&);
   LongSumAggregation(const SumPointData &);
 
   void Aggregate(int64_t value, const PointAttributes &attributes = {}) noexcept override;
@@ -44,7 +43,6 @@ class DoubleSumAggregation : public Aggregation
 {
 public:
   DoubleSumAggregation(bool is_monotonic);
-  DoubleSumAggregation(SumPointData &&);
   DoubleSumAggregation(const SumPointData &);
 
   void Aggregate(int64_t /* value */, const PointAttributes & /* attributes */) noexcept override {}

sdk/src/logs/batch_log_record_processor.cc

@@ -99,7 +99,7 @@ void BatchLogRecordProcessor::OnEmit(std::unique_ptr<Recordable> &&record) noexc
     return;
   }
 
-  if (buffer_.Add(std::unique_ptr<Recordable>(record.release())) == false)
+  if (buffer_.Add(std::move(record)) == false)
   {
     return;
   }