Skip to content

Commit 0e64897

Browse files
dbarkerdbarker
authored
[CODE HEALTH] Fix more clang-tidy warnings in api (open-telemetry#3950)
1 parent 2a6062b commit 0e64897

24 files changed

+167
-34
lines changed

‎.github/workflows/clang-tidy.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ jobs:
1717
matrix:
1818
include:
1919
- cmake_options: all-options-abiv1-preview
20-
warning_limit: 170
20+
warning_limit: 104
2121
- cmake_options: all-options-abiv2-preview
22-
warning_limit: 166
22+
warning_limit: 105
2323
env:
2424
CC: /usr/bin/clang-18
2525
CXX: /usr/bin/clang++-18

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ Increment the:
1818
* [CODE HEALTH] Fix clang tidy warnings in API `common` and `context`
1919
[#3948](https://github.com/open-telemetry/opentelemetry-cpp/pull/3948)
2020

21+
* [CODE HEALTH] Fix more clang-tidy warnings in SDK
22+
[#3951](https://github.com/open-telemetry/opentelemetry-cpp/pull/3951)
23+
24+
* [CODE HEALTH] Fix more clang-tidy warnings in API
25+
[#3950](https://github.com/open-telemetry/opentelemetry-cpp/pull/3950)
26+
2127
## [1.26.0] 2026-03-19
2228

2329
* [RELEASE] Bump main branch to 1.26.0-dev

‎api/include/opentelemetry/logs/event_logger.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ namespace logs
2222
class EventLogger
2323
{
2424
public:
25-
virtual ~EventLogger() = default;
25+
EventLogger() = default;
26+
EventLogger(const EventLogger &) = default;
27+
EventLogger(EventLogger &&) noexcept = default;
28+
EventLogger &operator=(const EventLogger &) = default;
29+
EventLogger &operator=(EventLogger &&) noexcept = default;
30+
virtual ~EventLogger() = default;
2631

2732
/* Returns the name of the logger */
2833
virtual const nostd::string_view GetName() noexcept = 0;

‎api/include/opentelemetry/logs/event_logger_provider.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ class Logger;
2222
class EventLoggerProvider
2323
{
2424
public:
25-
virtual ~EventLoggerProvider() = default;
25+
EventLoggerProvider() = default;
26+
EventLoggerProvider(const EventLoggerProvider &) = default;
27+
EventLoggerProvider(EventLoggerProvider &&) noexcept = default;
28+
EventLoggerProvider &operator=(const EventLoggerProvider &) = default;
29+
EventLoggerProvider &operator=(EventLoggerProvider &&) noexcept = default;
30+
virtual ~EventLoggerProvider() = default;
2631

2732
/**
2833
* Creates a named EventLogger instance.

‎api/include/opentelemetry/logs/log_record.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,12 @@ enum class Severity : uint8_t;
2828
class LogRecord
2929
{
3030
public:
31-
virtual ~LogRecord() = default;
31+
LogRecord() = default;
32+
LogRecord(const LogRecord &) = default;
33+
LogRecord(LogRecord &&) noexcept = default;
34+
LogRecord &operator=(const LogRecord &) = default;
35+
LogRecord &operator=(LogRecord &&) noexcept = default;
36+
virtual ~LogRecord() = default;
3237

3338
/**
3439
* Set the timestamp for this log.

‎api/include/opentelemetry/logs/logger.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@ class LogRecord;
2727
class Logger
2828
{
2929
public:
30-
virtual ~Logger() = default;
30+
Logger() = default;
31+
Logger(const Logger &) = default;
32+
Logger(Logger &&) noexcept = default;
33+
Logger &operator=(const Logger &) = default;
34+
Logger &operator=(Logger &&) noexcept = default;
35+
virtual ~Logger() = default;
3136

3237
/* Returns the name of the logger */
3338
virtual const nostd::string_view GetName() noexcept = 0;

‎api/include/opentelemetry/logs/logger_provider.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ class Logger;
2323
class OPENTELEMETRY_EXPORT LoggerProvider
2424
{
2525
public:
26-
virtual ~LoggerProvider() = default;
26+
LoggerProvider() = default;
27+
LoggerProvider(const LoggerProvider &) = default;
28+
LoggerProvider(LoggerProvider &&) noexcept = default;
29+
LoggerProvider &operator=(const LoggerProvider &) = default;
30+
LoggerProvider &operator=(LoggerProvider &&) noexcept = default;
31+
virtual ~LoggerProvider() = default;
2732

2833
/**
2934
* Gets or creates a named Logger instance.

‎api/include/opentelemetry/logs/logger_type_traits.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ template <>
4545
struct LogRecordSetterTrait<EventId>
4646
{
4747
template <class ArgumentType>
48-
inline static LogRecord *Set(LogRecord *log_record, ArgumentType &&arg) noexcept
48+
inline static LogRecord *Set(LogRecord *log_record, const ArgumentType &arg) noexcept
4949
{
5050
log_record->SetEventId(arg.id_, nostd::string_view{arg.name_.get()});
5151

@@ -57,7 +57,7 @@ template <>
5757
struct LogRecordSetterTrait<trace::SpanContext>
5858
{
5959
template <class ArgumentType>
60-
inline static LogRecord *Set(LogRecord *log_record, ArgumentType &&arg) noexcept
60+
inline static LogRecord *Set(LogRecord *log_record, const ArgumentType &arg) noexcept
6161
{
6262
log_record->SetSpanId(arg.span_id());
6363
log_record->SetTraceId(arg.trace_id());
@@ -131,7 +131,7 @@ template <>
131131
struct LogRecordSetterTrait<common::KeyValueIterable>
132132
{
133133
template <class ArgumentType>
134-
inline static LogRecord *Set(LogRecord *log_record, ArgumentType &&arg) noexcept
134+
inline static LogRecord *Set(LogRecord *log_record, const ArgumentType &arg) noexcept
135135
{
136136
arg.ForEachKeyValue(
137137
[&log_record](nostd::string_view key, common::AttributeValue value) noexcept {
@@ -173,7 +173,7 @@ struct LogRecordSetterTrait
173173
template <class ArgumentType,
174174
nostd::enable_if_t<common::detail::is_key_value_iterable<ArgumentType>::value, int> * =
175175
nullptr>
176-
inline static LogRecord *Set(LogRecord *log_record, ArgumentType &&arg) noexcept
176+
inline static LogRecord *Set(LogRecord *log_record, const ArgumentType &arg) noexcept
177177
{
178178
for (auto &argv : arg)
179179
{

‎api/include/opentelemetry/logs/noop.h‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,16 @@ class NoopLogger final : public Logger
4646

4747
using Logger::EmitLogRecord;
4848

49-
void EmitLogRecord(nostd::unique_ptr<LogRecord> &&) noexcept override {}
49+
void EmitLogRecord(nostd::unique_ptr<LogRecord> &&log_record) noexcept override
50+
{
51+
auto local = std::move(log_record);
52+
local.reset();
53+
}
5054

5155
private:
5256
class NoopLogRecord : public LogRecord
5357
{
5458
public:
55-
NoopLogRecord() = default;
56-
~NoopLogRecord() override = default;
57-
5859
void SetTimestamp(common::SystemTimestamp /* timestamp */) noexcept override {}
5960
void SetObservedTimestamp(common::SystemTimestamp /* timestamp */) noexcept override {}
6061
void SetSeverity(logs::Severity /* severity */) noexcept override {}
@@ -99,13 +100,16 @@ class NoopEventLogger final : public EventLogger
99100
{
100101
public:
101102
NoopEventLogger() : logger_{nostd::shared_ptr<NoopLogger>(new NoopLogger())} {}
102-
~NoopEventLogger() override = default;
103103

104104
const nostd::string_view GetName() noexcept override { return "noop event logger"; }
105105

106106
nostd::shared_ptr<Logger> GetDelegateLogger() noexcept override { return logger_; }
107107

108-
void EmitEvent(nostd::string_view, nostd::unique_ptr<LogRecord> &&) noexcept override {}
108+
void EmitEvent(nostd::string_view, nostd::unique_ptr<LogRecord> &&log_record) noexcept override
109+
{
110+
auto local = std::move(log_record);
111+
local.reset();
112+
}
109113

110114
private:
111115
nostd::shared_ptr<Logger> logger_;
@@ -120,7 +124,6 @@ class NoopEventLoggerProvider final : public EventLoggerProvider
120124
public:
121125
NoopEventLoggerProvider() : event_logger_{nostd::shared_ptr<EventLogger>(new NoopEventLogger())}
122126
{}
123-
~NoopEventLoggerProvider() override = default;
124127

125128
nostd::shared_ptr<EventLogger> CreateEventLogger(
126129
nostd::shared_ptr<Logger> /*delegate_logger*/,

‎api/include/opentelemetry/metrics/async_instruments.h‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,12 @@ using ObservableCallbackPtr = void (*)(ObserverResult, void *);
1515
class ObservableInstrument
1616
{
1717
public:
18-
ObservableInstrument() = default;
19-
virtual ~ObservableInstrument() = default;
18+
ObservableInstrument() = default;
19+
ObservableInstrument(const ObservableInstrument &) = default;
20+
ObservableInstrument(ObservableInstrument &&) noexcept = default;
21+
ObservableInstrument &operator=(const ObservableInstrument &) = default;
22+
ObservableInstrument &operator=(ObservableInstrument &&) noexcept = default;
23+
virtual ~ObservableInstrument() = default;
2024

2125
/**
2226
* Sets up a function that will be called whenever a metric collection is initiated.

0 commit comments

Comments
 (0)