[CodeHealth] Fix clang-tidy warnings part 3 (open-telemetry#3498)

Author: dbarker

.github/workflows/clang-tidy.yaml

@@ -17,9 +17,9 @@ jobs:
       matrix:
         include:
           - cmake_options: all-options-abiv1-preview
-            warning_limit: 109
+            warning_limit: 86
           - cmake_options: all-options-abiv2-preview
-            warning_limit: 109
+            warning_limit: 86
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@002fdce3c6a235733a90a27c80493a3241e56863 # v2.12.1

CHANGELOG.md

@@ -36,6 +36,9 @@ Increment the:
 * [CodeHealth] Fix clang-tidy warnings part 2
   [#3496](https://github.com/open-telemetry/opentelemetry-cpp/pull/3496)
 
+* [CodeHealth] Fix clang-tidy warnings part 3
+  [#3496](https://github.com/open-telemetry/opentelemetry-cpp/pull/3498)
+
 Important changes:
 
 * [REMOVAL] Removed deprecated semantic convention header files

api/test/context/propagation/composite_propagator_test.cc

@@ -73,13 +73,11 @@ class CompositePropagatorTest : public ::testing::Test
     propogator_list.push_back(std::move(b3_propogator));
 
     composite_propagator_ =
-        new context::propagation::CompositePropagator(std::move(propogator_list));
+        std::make_shared<context::propagation::CompositePropagator>(std::move(propogator_list));
   }
 
-  ~CompositePropagatorTest() override { delete composite_propagator_; }
-
 protected:
-  context::propagation::CompositePropagator *composite_propagator_;
+  std::shared_ptr<context::propagation::CompositePropagator> composite_propagator_;
 };
 
 TEST_F(CompositePropagatorTest, Extract)

api/test/nostd/shared_ptr_test.cc

@@ -19,6 +19,11 @@ class A
 
   ~A() { destructed_ = true; }
 
+  A(const A &)            = delete;
+  A(A &&)                 = delete;
+  A &operator=(const A &) = delete;
+  A &operator=(A &&)      = delete;
+
 private:
   bool &destructed_;
 };
@@ -33,13 +38,16 @@ class C
 {
 public:
   virtual ~C() {}
+  C() = default;
+
+  C(const C &)            = delete;
+  C(C &&)                 = delete;
+  C &operator=(const C &) = delete;
+  C &operator=(C &&)      = delete;
 };
 
 class D : public C
-{
-public:
-  ~D() override {}
-};
+{};
 
 TEST(SharedPtrTest, DefaultConstruction)
 {

api/test/nostd/unique_ptr_test.cc

@@ -17,6 +17,11 @@ class A
 
   ~A() { destructed_ = true; }
 
+  A(const A &)            = delete;
+  A(A &&)                 = delete;
+  A &operator=(const A &) = delete;
+  A &operator=(A &&)      = delete;
+
 private:
   bool &destructed_;
 };

api/test/nostd/variant_test.cc

@@ -14,6 +14,11 @@ class DestroyCounter
   explicit DestroyCounter(int *count) : count_{count} {}
   ~DestroyCounter() { ++*count_; }
 
+  DestroyCounter(const DestroyCounter &)            = default;
+  DestroyCounter &operator=(const DestroyCounter &) = default;
+  DestroyCounter(DestroyCounter &&)                 = default;
+  DestroyCounter &operator=(DestroyCounter &&)      = default;
+
 private:
   int *count_;
 };

examples/otlp/http_instrumented_main.cc

@@ -89,7 +89,6 @@ class MyThreadInstrumentation : public opentelemetry::sdk::common::ThreadInstrum
                           const std::string &priority)
       : thread_name_(thread_name), network_name_(network_name), priority_(priority)
   {}
-  ~MyThreadInstrumentation() override = default;
 
   void OnStart() override
   {

examples/plugin/plugin/tracer.cc

@@ -35,6 +35,11 @@ class Span final : public trace::Span
 
   ~Span() override { std::cout << "~Span\n"; }
 
+  Span(const Span &)            = delete;
+  Span &operator=(const Span &) = delete;
+  Span(Span &&)                 = delete;
+  Span &operator=(Span &&)      = delete;
+
   // opentelemetry::trace::Span
   void SetAttribute(nostd::string_view /*name*/,
                     const common::AttributeValue & /*value*/) noexcept override

exporters/elasticsearch/src/es_log_record_exporter.cc

@@ -223,6 +223,11 @@ class AsyncResponseHandler : public http_client::EventHandler
         console_debug_{console_debug}
   {}
 
+  AsyncResponseHandler(const AsyncResponseHandler &)            = delete;
+  AsyncResponseHandler &operator=(const AsyncResponseHandler &) = delete;
+  AsyncResponseHandler(AsyncResponseHandler &&)                 = delete;
+  AsyncResponseHandler &operator=(AsyncResponseHandler &&)      = delete;
+
   /**
    * Cleans up the session in the destructor.
    */

exporters/otlp/src/otlp_grpc_client.cc

@@ -67,8 +67,12 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpGrpcAsyncCallDataBase
       opentelemetry::sdk::common::ExportResult::kFailure;
   GrpcAsyncCallback grpc_async_callback = nullptr;
 
-  OtlpGrpcAsyncCallDataBase() {}
-  virtual ~OtlpGrpcAsyncCallDataBase() {}
+  OtlpGrpcAsyncCallDataBase()                                             = default;
+  virtual ~OtlpGrpcAsyncCallDataBase()                                    = default;
+  OtlpGrpcAsyncCallDataBase(const OtlpGrpcAsyncCallDataBase &)            = delete;
+  OtlpGrpcAsyncCallDataBase &operator=(const OtlpGrpcAsyncCallDataBase &) = delete;
+  OtlpGrpcAsyncCallDataBase(OtlpGrpcAsyncCallDataBase &&)                 = delete;
+  OtlpGrpcAsyncCallDataBase &operator=(OtlpGrpcAsyncCallDataBase &&)      = delete;
 };
 
 // When building with -fvisibility=default, we hide the symbols and vtable to ensure we always use
@@ -90,8 +94,7 @@ class OPENTELEMETRY_LOCAL_SYMBOL OtlpGrpcAsyncCallData : public OtlpGrpcAsyncCal
                      ResponseType *)>
       result_callback;
 
-  OtlpGrpcAsyncCallData() {}
-  ~OtlpGrpcAsyncCallData() override {}
+  OtlpGrpcAsyncCallData() = default;
 };
 }  // namespace
 #endif