File tree Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,9 @@ Increment the:
1515
1616## [ Unreleased]
1717
18+ * [ BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library
19+ [ #3440 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3440 )
20+
1821* [ BUILD] Error out when building DLL without MSVC
1922 [ #3438 ] ( https://github.com/open-telemetry/opentelemetry-cpp/pull/3438 )
2023
Original file line number Diff line number Diff line change @@ -12,4 +12,4 @@ endif()
1212
1313target_include_directories (common_foo_library
1414 PUBLIC "$<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR} >" )
15- target_link_libraries (common_foo_library PRIVATE opentelemetry-cpp::api)
15+ target_link_libraries (common_foo_library PUBLIC opentelemetry-cpp::api)
Original file line number Diff line number Diff line change @@ -13,4 +13,4 @@ endif()
1313target_include_directories (common_logs_foo_library
1414 PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR} >)
1515
16- target_link_libraries (common_logs_foo_library PRIVATE opentelemetry-cpp::api)
16+ target_link_libraries (common_logs_foo_library PUBLIC opentelemetry-cpp::api)
Original file line number Diff line number Diff line change @@ -13,4 +13,4 @@ endif()
1313target_include_directories (common_metrics_foo_library
1414 PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR} >)
1515
16- target_link_libraries (common_metrics_foo_library PRIVATE opentelemetry-cpp::api)
16+ target_link_libraries (common_metrics_foo_library PUBLIC opentelemetry-cpp::api)
You can’t perform that action at this time.
0 commit comments