Skip to content

Commit 7f047d5

Browse files
authored
[EXPORTER] Support exporting event_name using OTLP Exporter (open-telemetry#3277)
1 parent 2fdc022 commit 7f047d5

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

exporters/otlp/include/opentelemetry/exporters/otlp/otlp_log_recordable.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,7 @@ class OtlpLogRecordable final : public opentelemetry::sdk::logs::Recordable
7676
* @param id the event Id to set
7777
* @param name the event name to set
7878
*/
79-
void SetEventId(int64_t /* id */, nostd::string_view /* name */) noexcept override
80-
{
81-
// TODO: export Event Id to OTLP
82-
}
79+
void SetEventId(int64_t /* id */, nostd::string_view event_name) noexcept override;
8380

8481
/**
8582
* Set the trace id for this log.

exporters/otlp/src/otlp_log_recordable.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,11 @@ void OtlpLogRecordable::SetBody(const opentelemetry::common::AttributeValue &mes
197197
OtlpPopulateAttributeUtils::PopulateAnyValue(proto_record_.mutable_body(), message);
198198
}
199199

200+
void OtlpLogRecordable::SetEventId(int64_t /* id */, nostd::string_view event_name) noexcept
201+
{
202+
proto_record_.set_event_name(event_name.data(), event_name.size());
203+
}
204+
200205
void OtlpLogRecordable::SetTraceId(const opentelemetry::trace::TraceId &trace_id) noexcept
201206
{
202207
if (trace_id.IsValid())

exporters/otlp/test/otlp_log_recordable_test.cc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,16 @@ TEST(OtlpLogRecordable, SetInstrumentationScope)
174174
EXPECT_EQ(&rec.GetInstrumentationScope(), inst_lib.get());
175175
}
176176

177+
TEST(OtlpLogRecordable, SetEventName)
178+
{
179+
OtlpLogRecordable rec;
180+
181+
nostd::string_view event_name = "Test Event";
182+
rec.SetEventId(0, event_name);
183+
184+
EXPECT_EQ(rec.log_record().event_name(), event_name);
185+
}
186+
177187
/**
178188
* AttributeValue can contain different int types, such as int, int64_t,
179189
* unsigned int, and uint64_t. To avoid writing test cases for each, we can

0 commit comments

Comments
 (0)