fixes #794 Shouldn't be able to set trading to active if you page is not set to public

Author: marcelpanse

frontend/public/locales/de-DE/trade-matches.json

@@ -47,6 +47,7 @@
   "viewTradePartner": "View matches",
   "noTradePartners": "We couldn't find anyone for you to trade with.",
   "isActiveTrading": "Accepting new trades",
+  "isActiveTradingDisabledTooltip": "Du musst dein Profil öffentlich machen, bevor du den aktiven Tausch aktivieren kannst.",
   "toCollectTooltip": "The amount of cards you want to collect by trading. Tip: Set this value to 0 to exclude a rarity from trading.",
   "toKeepTooltip": "The minimum amount of cards you want to trade down to.",
   "tabMatches": "Matches",

frontend/public/locales/en-US/trade-matches.json

@@ -16,6 +16,7 @@
   "noPossibleTradesDescription": "No trades between you and your friend are currently possible.",
   "featureDescription": "This dialog will show you the possible trades between your cards and that of the selected friend ID. It shows you duplicate cards that the other party doesn't own yet.",
   "isActiveTrading": "Accepting new trades",
+  "isActiveTradingDisabledTooltip": "You must make your profile public before enabling active trading.",
   "inActiveTradePage": "The user \"{{username}}\" is currently not accepting any trades.",
   "inActiveTradeDescription": "Their trading page is set to disabled. Please contact them if you want to trade.",
   "toCollectTooltip": "The amount of cards you want to collect by trading. Tip: Set this value to 0 to exclude a rarity from trading.",

frontend/public/locales/es-ES/trade-matches.json

@@ -53,6 +53,7 @@
   "noAccount": "First set up your account using 'Edit profile' in the top right corner.",
   "longOperation": "This might take a while.",
   "isActiveTrading": "Accepting new trades",
+  "isActiveTradingDisabledTooltip": "Debes hacer público tu perfil antes de habilitar el intercambio activo.",
   "toCollectTooltip": "The amount of cards you want to collect by trading. Tip: Set this value to 0 to exclude a rarity from trading.",
   "toKeepTooltip": "The minimum amount of cards you want to trade down to.",
   "search": {

frontend/public/locales/fr-FR/trade-matches.json

@@ -15,6 +15,7 @@
   "noPossibleTrades": "Aucun échange possible.",
   "noPossibleTradesDescription": "Aucun échange entre vous et votre ami(e) n'est actuellement possible.",
   "featureDescription": "Cette boîte de dialogue affiche les échanges possibles entre vos cartes et celles de l'ID de l'ami(e) sélectionné(e). Elle montre les cartes en double que l'autre personne ne possède pas encore.",
+  "isActiveTradingDisabledTooltip": "Vous devez rendre votre profil public avant d'activer les échanges.",
   "inActiveTradePage": "L'utilisateur « {{username}} » n'accepte actuellement aucun échange.",
   "inActiveTradeDescription": "Leur page d'échanges est désactivée. Veuillez les contacter si vous souhaitez faire un échange.",
   "accountSaved": "Compte enregistré.",

frontend/public/locales/it-IT/trade-matches.json

@@ -55,6 +55,7 @@
   "noAccount": "First set up your account using 'Edit profile' in the top right corner.",
   "longOperation": "This might take a while.",
   "isActiveTrading": "Accepting new trades",
+  "isActiveTradingDisabledTooltip": "Devi rendere pubblico il tuo profilo prima di abilitare lo scambio attivo.",
   "toCollectTooltip": "The amount of cards you want to collect by trading. Tip: Set this value to 0 to exclude a rarity from trading.",
   "toKeepTooltip": "The minimum amount of cards you want to trade down to.",
   "search": {

frontend/public/locales/pt-BR/trade-matches.json

@@ -51,6 +51,7 @@
   "toKeep": "To keep",
   "longOperation": "This might take a while.",
   "isActiveTrading": "Accepting new trades",
+  "isActiveTradingDisabledTooltip": "Você deve tornar seu perfil público antes de ativar a troca ativa.",
   "toCollectTooltip": "The amount of cards you want to collect by trading. Tip: Set this value to 0 to exclude a rarity from trading.",
   "toKeepTooltip": "The minimum amount of cards you want to trade down to.",
   "search": {

frontend/src/components/EditProfile.tsx

@@ -48,6 +48,7 @@ const EditProfile: FC = () => {
         username: values.username,
         friend_id: values.friend_id,
         is_public: values.is_public,
+        is_active_trading: values.is_public === false ? false : account?.is_active_trading,
       } as AccountRow,
       {
         onSuccess: () => toast({ title: t('accountSaved'), variant: 'default' }),

frontend/src/pages/trade/TradeSettings.tsx

@@ -74,7 +74,24 @@ function TradeSettings() {
                 <FormControl>
                   <FormLabel className="flex">
                     {t('isActiveTrading')}
-                    <Switch className="ml-2" checked={field.value} onCheckedChange={field.onChange} />
+                    <Switch
+                      className="ml-2"
+                      checked={field.value}
+                      onCheckedChange={field.onChange}
+                      disabled={!account?.is_public}
+                      data-tooltip-id="is-active-trading-disabled"
+                      data-tooltip-content={!account?.is_public ? t('isActiveTradingDisabledTooltip') : undefined}
+                    />
+                    {!account?.is_public && (
+                      <>
+                        <Tooltip id="is-active-trading-disabled" />
+                        <CircleHelp
+                          className="size-4 ml-1"
+                          data-tooltip-id="is-active-trading-disabled"
+                          data-tooltip-content={t('isActiveTradingDisabledTooltip')}
+                        />
+                      </>
+                    )}
                   </FormLabel>
                 </FormControl>
               </FormItem>