-
Notifications
You must be signed in to change notification settings - Fork 40
Description
Problems with limitlesstcg
There has been #749 which arisen from inconsistency in promo cards rarity on limitlesstcg. Also identifying reprints is currently rather fragile, and might break with new sets.
Change card database structure
I also argued during the migration from card_id to internal_id that we shouldn't duplicate cards in the cards.json array when there appear in multiple expansion. Meaning:
// currently
[
{
"expansion": "A2b",
"card_id": "A2b-1",
"internal_id": 327744,
// all other properties
},
{
"expansion": "A4b",
"card_id": "A4b-6",
"internal_id": 327744,
// every single property repeated again
},
// other cards
]
// should be
[
{
"expansions": [
{ "expansion": "A2b", "number": 1 },
{ "expansion": "A4b", "number": 6 },
],
"internal_id": 65600,
// all other properties
},
// other cards
]Then in another file we can for each expansion store the list of cards (internal ids) that appear in this expansion.
Advantages of Pokemon Zone
https://www.pokemon-zone.com/sets/b1/
https://www.pokemon-zone.com/cards/a4b/1/bulbasaur/
First of all, they actually scrape the game data, so their data should be the highest quality and we can more or less trust it that there won't be any inconsistencies caused by them (like the inconsistency of promo cards rarity on limitlesstcg).
Promo rarities
When on the topic of promo rarities, they actually also assign them (to all promo cards, including P-A). This suggests that they actually have it somewhere in the game code. But the game interface puts them into a separate "promo" rarity (and you can't find them when filtering for non-promo rarities). Next thing that the game is so messy about...
One card in multiple expansions
They actually have a separate table for this, so it will be much more robust.
Evolution line
They include what pokemon the current one can evolve into, allowing us to implement #656.