proto/crypto: rename HeaderAndBody (scionproto#4840)

Rename the internal message HeaderAndBodyInternal to HeaderAndBody.
While it is internal and does not appear on the wire, we still need to
reference the message in the specification. Having internal in the name
can be confusing.

---------

Co-authored-by: Roman Sharkov <roman.scharkov@gmail.com>

Author: oncilla

pkg/proto/crypto/signed.pb.go

@@ -81,7 +81,7 @@ func Sign(hdr Header, body []byte, signer crypto.Signer,
 	if err != nil {
 		return nil, serrors.Wrap("packing header", err)
 	}
-	hdrAndBody := &cryptopb.HeaderAndBodyInternal{
+	hdrAndBody := &cryptopb.HeaderAndBody{
 		Header: rawHdr,
 		Body:   body,
 	}
@@ -205,7 +205,7 @@ func extractHeaderAndBody(signed *cryptopb.SignedMessage) (*Header, []byte, erro
 	if signed == nil {
 		return nil, nil, serrors.New("nil message")
 	}
-	var hdrAndBody cryptopb.HeaderAndBodyInternal
+	var hdrAndBody cryptopb.HeaderAndBody
 	if err := proto.Unmarshal(signed.HeaderAndBody, &hdrAndBody); err != nil {
 		return nil, nil, err
 	}

pkg/scrypto/signed/msg.go

@@ -361,7 +361,7 @@ func TestVerify(t *testing.T) {
 				priv, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
 				require.NoError(t, err)
 
-				hdrAndBody := &cryptopb.HeaderAndBodyInternal{
+				hdrAndBody := &cryptopb.HeaderAndBody{
 					Header: []byte("someweirdmalformedthingy"),
 					Body:   []byte("body"),
 				}

pkg/scrypto/signed/msg_test.go

@@ -187,7 +187,7 @@ func TestAPI(t *testing.T) {
 						if err != nil {
 							return nil, serrors.Wrap("packing header", err)
 						}
-						hdrAndBody := &cryptopb.HeaderAndBodyInternal{
+						hdrAndBody := &cryptopb.HeaderAndBody{
 							Header: rawHdr,
 							Body:   msg,
 						}

private/mgmtapi/segments/api/api_test.go

@@ -56,7 +56,7 @@ message Header {
 
 // Low-level representation of HeaderAndBody used for signature computation
 // input. This should not be used by external code.
-message HeaderAndBodyInternal {
+message HeaderAndBody {
     // Enocded header suitable for signature computation.
     bytes header = 1;
     // Raw payload suitable for signature computation.