Fixed holiday-only effects and obsoleted the Hubert Moon prefab

Author: marchellcx

LabExtended/API/Containers/EffectContainer.cs

@@ -19,6 +19,7 @@
 using LabApi.Events.Arguments.PlayerEvents;
 
 using UnityEngine;
+
 using InventorySystem.Items.MarshmallowMan;
 // ReSharper disable UnusedAutoPropertyAccessor.Local
 
@@ -560,6 +561,9 @@ internal EffectContainer(PlayerEffectsController controller, ExPlayer player)
                     if (!warnedMissing.Add(prop.PropertyType))
                         continue;
 
+                    if (typeof(IHolidayEffect).IsAssignableFrom(prop.PropertyType))
+                        continue;
+
                     ApiLog.Error("LabExtended", $"Missing effect for property &3{prop.Name}&r (&1{prop.PropertyType.FullName}&r)");
                 }
             }

LabExtended/API/ExMap.cs

@@ -124,11 +124,14 @@ public static bool IsHubertSkyboxActive
     }
 
     /// <summary>
-    /// Spawns a Hubert Moon instance.
-    /// </summary>
-    /// <returns>The spawned Hubert Moon instance.</returns>
-    public static HubertMoon SpawnHubertMoon()
-        => PrefabList.HubertMoon.Spawn<HubertMoon>();
+    /// Spawns an instance of Hubert Moon if available.
+    /// </summary>
+    /// <remarks>This method is obsolete. Hubert Moon is no longer available in the game and this method will
+    /// always return <see langword="null"/>.</remarks>
+    /// <returns>A <see cref="HubertMoon"/> instance if Hubert Moon is available; otherwise, <see langword="null"/>.</returns>
+    [Obsolete("Hubert Moon is no longer available in the game.")]
+    public static HubertMoon? SpawnHubertMoon()
+        => null;
     #endregion
 
     /// <summary>

LabExtended/API/Prefabs/PrefabList.cs

@@ -1,6 +1,8 @@
 using LabExtended.Core;
 using LabExtended.Extensions;
+
 using MapGeneration.Holidays;
+
 using Mirror;
 
 namespace LabExtended.API.Prefabs;
@@ -484,7 +486,8 @@ public static IReadOnlyDictionary<string, PrefabDefinition> AllPrefabs
     /// <summary>
     /// Gets the prefab of Hubert Moon.
     /// </summary>
-    public static PrefabDefinition HubertMoon { get; } = new("Hubert Moon");
+    [Obsolete("Hubert Moon has been removed from the game due to the end of Halloween.", true)]
+    public static PrefabDefinition? HubertMoon { get; }
 
     /// <summary>
     /// Gets the prefab of an elevator's gate.