Hide SPC, the feature needs stabilization

Author: marcinotorowski

CHANGELOG.md

@@ -6,7 +6,6 @@ Breaking changes:
 New features:
 * It is now possible to show packages in a specific folder (83b31861, e5c64e05, 8639ab33)
 * PSF analyzer now supports [MSIX Helper](https://techcommunity.microsoft.com/discussions/msix-discussions/msix-helper/3935229)  (dbad0b95)
-* A new screen for managing Shared Package Containers (c2986972)
 
 Improvements:
 * Support for human-friendly display of Windows 11 versions 22H2, 23H2, and 24H2 (5fc1ce2f)

src/Otor.MsixHero.App/Hero/Handlers/GetSharedPackageContainersHandler.cs

@@ -24,20 +24,24 @@
 using Otor.MsixHero.App.Mvvm.Progress;
 using Otor.MsixHero.Appx.Packaging.SharedPackageContainer;
 using Otor.MsixHero.Appx.Packaging.SharedPackageContainer.Entities;
+using Otor.MsixHero.Elevation;
 
 namespace Otor.MsixHero.App.Hero.Handlers;
 
 public class GetSharedPackageContainersHandler : IRequestHandler<GetSharedPackageContainersCommand, IList<SharedPackageContainer>>
 {
+    private readonly IUacElevation _uacElevation;
     private readonly IAppxSharedPackageContainerService _containerService;
     private readonly IMsixHeroCommandExecutor _commandExecutor;
     private readonly IBusyManager _busyManager;
 
     public GetSharedPackageContainersHandler(
+        IUacElevation uacElevation,
         IMsixHeroCommandExecutor commandExecutor,
         IBusyManager busyManager,
         IAppxSharedPackageContainerService containerService)
     {
+        _uacElevation = uacElevation;
         this._containerService = containerService;
         this._commandExecutor = commandExecutor;
         this._busyManager = busyManager;

src/Otor.MsixHero.App/Modules/Containers/Commands/ContainersCommandHandler.cs

@@ -107,7 +107,7 @@ private async void OnDelete()
             }
             catch (Exception e)
             {
-                this._interactionService.ShowError("The container could not be reset. " + e.GetBaseException().Message);
+                this._interactionService.ShowError("The container could not be deleted. " + e.GetBaseException().Message);
                 return;
             }
             finally

src/Otor.MsixHero.App/Modules/Dialogs/Settings/View/SettingsView.xaml

@@ -204,7 +204,7 @@
                                 SelectedValuePath="Tag"
                                 SelectedValue="{Binding DefaultScreen.CurrentValue}">
                                 <ComboBoxItem Tag="{x:Static configuration:DefaultScreen.Packages}" Content="{localization:Loc Dialogs_Settings_InitialScreen_Packages}" />
-                                <ComboBoxItem Tag="{x:Static configuration:DefaultScreen.Containers}" Content="{localization:Loc Dialogs_Settings_InitialScreen_Containers}" />
+                                <!--<ComboBoxItem Tag="{x:Static configuration:DefaultScreen.Containers}" Content="{localization:Loc Dialogs_Settings_InitialScreen_Containers}" />-->
                                 <ComboBoxItem Tag="{x:Static configuration:DefaultScreen.Volumes}" Content="{localization:Loc Dialogs_Settings_InitialScreen_Volumes}" />
                                 <ComboBoxItem Tag="{x:Static configuration:DefaultScreen.Events}" Content="{localization:Loc Dialogs_Settings_InitialScreen_EventViewer}" />
                                 <ComboBoxItem Tag="{x:Static configuration:DefaultScreen.System}" Content="{localization:Loc Dialogs_Settings_InitialScreen_SystemState}" />

src/Otor.MsixHero.App/Modules/Main/Sidebar/ViewModels/SidebarViewModel.cs

@@ -66,10 +66,10 @@ public SidebarViewModel(
                     NavigationPaths.PackageManagement,
                     TabPackages),
 
-                 new SidebarItemViewModel(
+                 /*new SidebarItemViewModel(
                      ApplicationMode.Containers,
                      NavigationPaths.Containers,
-                     TabContainer),
+                     TabContainer),*/
 
                 new SidebarItemViewModel(
                     ApplicationMode.VolumeManager,

src/Otor.MsixHero.Appx/Packaging/SharedPackageContainer/AppxSharedPackageContainerService.cs

@@ -27,25 +27,53 @@
 using Otor.MsixHero.Appx.Packaging.SharedPackageContainer.Entities;
 using Otor.MsixHero.Appx.Packaging.SharedPackageContainer.Exceptions;
 using Otor.MsixHero.Infrastructure.Helpers;
+using Otor.MsixHero.Infrastructure.ThirdParty.PowerShell;
 
 namespace Otor.MsixHero.Appx.Packaging.SharedPackageContainer;
 
 public class AppxSharedPackageContainerService : IAppxSharedPackageContainerService
 {
+    public AppxSharedPackageContainerService()
+    {
+    }
+
     private Lazy<SharedPackageContainerManager> _manager = new(SharedPackageContainerManager.GetDefault);
 
-    public Task<IList<Entities.SharedPackageContainer>> GetAll(CancellationToken cancellationToken = default)
+    public async Task<IList<Entities.SharedPackageContainer>> GetAll(CancellationToken cancellationToken = default)
     {
-        var containers = this._manager.Value.FindContainers(new FindSharedPackageContainerOptions());
+        // Note: Some issues with SharedPackageContainerManager, let's revert to PowerShell
+        var pss = await PowerShellSession.CreateForAppxModule().ConfigureAwait(false);
+        pss.AddCommand("Get-AppSharedPackageContainer");
+        var powerShellResult = await pss.InvokeAsync().ConfigureAwait(false);
 
         IList<Entities.SharedPackageContainer> list = new List<Entities.SharedPackageContainer>();
+        foreach (var item in powerShellResult)
+        {
+            var propName = item.Properties.FirstOrDefault(p => p.Name == "Name")?.Value as string;
+            var propId = item.Properties.FirstOrDefault(p => p.Name == "Id")?.Value as string;
+            var propPackageFamilies = item.Properties.FirstOrDefault(p => p.Name == "PackageFamilyNames")?.Value as IList<string> ?? Array.Empty<string>();
+
+            var spc = new Entities.SharedPackageContainer()
+            {
+                Id = propId,
+                Name = propName,
+                PackageFamilies = propPackageFamilies.Select(pfn => new SharedPackageFamily { FamilyName = pfn }).ToList()
+            };
+
+            list.Add(spc);
+        }
+
+        return list;
+
+        var containers = this._manager.Value.FindContainers(new FindSharedPackageContainerOptions());
+
         foreach (var result in containers)
         {
 
             list.Add(SourceToSharedContainer(result));
         }
 
-        return Task.FromResult(list);
+        return list;
     }
 
     public async Task<Entities.SharedPackageContainer> Add(