Skip to content

Commit 4e90f82

Browse files
committed
Bug 1966633 [wpt PR 52565] - compute pressure: Add OwnContributionEstimate to API.,
Automatic update from web-platform-tests compute pressure: Add OwnContributionEstimate to API. This patch is the second part of the two patches patchset to implement OnwContributionEstimate feature described in [1]. The first patch for crbug.com/402033762 addressed the implementation-specific part, modifying //services and //content. This patch exposes OwnContributionEstimate to Compute Pressure API. The CDP has been also modified to also include a virtual estimate value. Testdriver code was also modified to support estimate as a virtual source input parameter. [1] https://w3c.github.io/compute-pressure/?experimental=1#the-owncontributionestimate-attribute Bug: 402033762 Change-Id: Ie4ff1294aea757700fb1cf6b5f22f18906867428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373001 Reviewed-by: Alex Rudenko <alexrudenkochromium.org> Reviewed-by: Reilly Grant <reillygchromium.org> Reviewed-by: Koji Ishii <kojiichromium.org> Reviewed-by: Danil Somsikov <dsvchromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandyintel.com> Cr-Commit-Position: refs/heads/main{#1460595} -- wpt-commits: 9c26aadd95c82cc819cb766ea69946467cf6d5ea wpt-pr: 52565 Differential Revision: https://phabricator.services.mozilla.com/D250621 UltraBlame original commit: 468bdc0360bf58e5e227ac664ad68843b4dacb82
1 parent 7898613 commit 4e90f82

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

testing/web-platform/tests/compute-pressure/compute_pressure_basic.https.window.js

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,35 @@ pressure_test(async (t) => {
3131
const observer = new PressureObserver(resolve);
3232
t.add_cleanup(() => observer.disconnect());
3333
observer.observe('cpu').catch(reject);
34-
update_virtual_pressure_source('cpu', 'critical').catch(reject);
34+
update_virtual_pressure_source('cpu', 'critical', 0.5).catch(reject);
3535
});
3636
assert_equals(1, changes.length);
3737
assert_equals(changes[0].state, 'critical');
3838
assert_equals(changes[0].source, 'cpu');
3939
assert_equals(typeof changes[0].time, 'number');
40+
assert_equals(typeof changes[0].ownContributionEstimate, 'number');
41+
assert_equals(changes[0].ownContributionEstimate, 0.5);
4042
}, 'Basic functionality test');
4143

44+
pressure_test(async (t) => {
45+
await create_virtual_pressure_source('cpu');
46+
t.add_cleanup(async () => {
47+
await remove_virtual_pressure_source('cpu');
48+
});
49+
50+
const changes = await new Promise((resolve, reject) => {
51+
const observer = new PressureObserver(resolve);
52+
t.add_cleanup(() => observer.disconnect());
53+
observer.observe('cpu').catch(reject);
54+
update_virtual_pressure_source('cpu', 'critical').catch(reject);
55+
});
56+
assert_equals(1, changes.length);
57+
assert_equals(changes[0].state, 'critical');
58+
assert_equals(changes[0].source, 'cpu');
59+
assert_equals(typeof changes[0].time, 'number');
60+
assert_equals(changes[0].ownContributionEstimate, null);
61+
}, 'Basic functionality test with no ownContributionEstimate');
62+
4263
pressure_test(async (t) => {
4364
await create_virtual_pressure_source('cpu');
4465
t.add_cleanup(async () => {

testing/web-platform/tests/compute-pressure/compute_pressure_duplicate_updates.https.window.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ pressure_test(async (t) => {
1919
const syncObserver = new SyncPressureObserver(t);
2020
await syncObserver.observer().observe('cpu');
2121

22-
await update_virtual_pressure_source('cpu', 'critical');
22+
await update_virtual_pressure_source('cpu', 'critical', 0.2);
2323
await syncObserver.waitForUpdate();
2424
assert_equals(syncObserver.changes()[0][0].state, 'critical');
2525

26-
await update_virtual_pressure_source('cpu', 'critical');
26+
await update_virtual_pressure_source('cpu', 'critical', 0.2);
2727
await new Promise(resolve => {t.step_timeout(resolve, 3000)});
2828
assert_equals(syncObserver.changes().length, 1);
2929

30-
await update_virtual_pressure_source('cpu', 'nominal');
30+
await update_virtual_pressure_source('cpu', 'nominal'), 0.2;
3131
await syncObserver.waitForUpdate();
3232
assert_equals(syncObserver.changes()[1][0].state, 'nominal');
3333

testing/web-platform/tests/compute-pressure/resources/worker-support.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ function remove_virtual_pressure_source(source) {
4343
return send_message({command: 'remove', params: [source]});
4444
}
4545

46-
function update_virtual_pressure_source(source, state) {
47-
return send_message({command: 'update', params: [source, state]});
46+
function update_virtual_pressure_source(source, state, estimate) {
47+
return send_message({command: 'update', params: [source, state, estimate]});
4848
}
4949

5050
const uuid = new URLSearchParams(location.search).get('uuid');

0 commit comments

Comments
 (0)