Bug 1979220 [wpt PR 53970] - Reland "[FedCM] Adding disconnect to reset test state.", a=testonly

marco-c · marco-c · commit 5268162f6812 · 2025-08-04T15:45:30.000Z
Automatic update from web-platform-tests Reland "[FedCM] Adding disconnect to reset test state." This is a reland of commit 35632c9ba41725c5fabdb14ea66b00af64f83796 Original change's description: > [FedCM] Adding disconnect to reset test state. > > Test results are affected because of previously run tests. > Disconnect helps in resetting the test state for each test case. > > Bug: 41482163 > Change-Id: Ib97c2ff69ba0d01f886947c0969190c778bb7986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780242 > Commit-Queue: Christian Biesinger <cbiesingerchromium.org> > Commit-Queue: Jaimukund Bhan <bhanjaimukundgmail.com> > Reviewed-by: Nicolás Peña <npmchromium.org> > Reviewed-by: Christian Biesinger <cbiesingerchromium.org> > Cr-Commit-Position: refs/heads/main{#1491540} Bug: 41482163 Change-Id: Ib7702a52ea5215993e74ea696d7bbf19a505a98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6784548 Commit-Queue: Jaimukund Bhan <bhanjaimukundgmail.com> Reviewed-by: Christian Biesinger <cbiesingerchromium.org> Reviewed-by: Nicolás Peña <npmchromium.org> Cr-Commit-Position: refs/heads/main{#1491717} -- wpt-commits: 8f41f6f6c950b5b921a6558e65cee20cdb7577e1 wpt-pr: 53970 UltraBlame original commit: 636b4e63c769b9c88c6e2a0485f0e7b5a7b12cee
diff --git a/testing/web-platform/tests/fedcm/fedcm-authz/fedcm-disclosure-text-shown.https.html b/testing/web-platform/tests/fedcm/fedcm-authz/fedcm-disclosure-text-shown.https.html
@@ -1,5 +1,6 @@
 <!DOCTYPE html>
 <title>Federated Credential Management API network request tests.</title>
+<meta name="timeout" content="long">
 <link rel="help" href="https://fedidcg.github.io/FedCM">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/testing/web-platform/tests/fedcm/fedcm-context.https.html b/testing/web-platform/tests/fedcm/fedcm-context.https.html
@@ -1,5 +1,6 @@
 <!DOCTYPE html>
 <title>Federated Credential Management API context tests.</title>
+<meta name="timeout" content="long">
 <link rel="help" href="https://fedidcg.github.io/FedCM">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
diff --git a/testing/web-platform/tests/fedcm/fedcm-multi-idp/fedcm-too-many-idps.https.html b/testing/web-platform/tests/fedcm/fedcm-multi-idp/fedcm-too-many-idps.https.html
@@ -22,7 +22,7 @@
       nonce: '2'
     });
   }
-  assert_throws_js(TypeError, navigator.credentials.get({
+  return promise_rejects_js(t, TypeError, navigator.credentials.get({
     identity: {
       providers: providers,
     }
diff --git a/testing/web-platform/tests/fedcm/fedcm-storage-access-api-autogrant.tentative.https.sub.html b/testing/web-platform/tests/fedcm/fedcm-storage-access-api-autogrant.tentative.https.sub.html
@@ -1,5 +1,6 @@
 <!DOCTYPE html>
 <title>Federated Credential Management API / Storage Access API autogrants tests.</title>
+<meta name="timeout" content="long">
 <link rel="help" href="https://fedidcg.github.io/FedCM">
 <link rel="help" href="https://privacycg.github.io/storage-access/">
 <script src="/resources/testharness.js"></script>
diff --git a/testing/web-platform/tests/fedcm/support/fedcm-helper.sub.js b/testing/web-platform/tests/fedcm/support/fedcm-helper.sub.js
@@ -130,20 +130,27 @@ export function fedcm_test(test_func, test_name) {
   promise_test(async t => {
     assert_implements(window.IdentityCredential, "FedCM is not supported");
 
-    try {
-      await navigator.credentials.preventSilentAccess();
-    } catch (ex) {
-      
-      
-    }
-
     
     try {
       await test_driver.set_fedcm_delay_enabled(false);
     } catch (e) {
       
     }
 
+    t.add_cleanup(async () => {
+      try {
+        await IdentityCredential.disconnect(alt_disconnect_options(""));
+      } catch (ex){
+        
+      }
+
+      try {
+        await IdentityCredential.disconnect(disconnect_options(""));
+      } catch (ex){
+        
+      }
+    });
+
     await set_fedcm_cookie();
     await set_alt_fedcm_cookie();
     await test_func(t);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`nonce: '2'`
`23`	`23`	`});`
`24`	`24`	`}`
`25`		`- assert_throws_js(TypeError, navigator.credentials.get({`
	`25`	`+ return promise_rejects_js(t, TypeError, navigator.credentials.get({`
`26`	`26`	`identity: {`
`27`	`27`	`providers: providers,`
`28`	`28`	`}`