Skip to content

Commit 56e9ba8

Browse files
committed
Reapply "Bug 1967834 - remove the preprocessing scripts in favor of direct changes in gn_processor.py r=ng".
This reverts commit 946f65307b1377e305dbbd65fa43009b34f39604. UltraBlame original commit: 73cae34a99b20564f13d0eac36c0fb46528bf27b
1 parent ec54faa commit 56e9ba8

File tree

5 files changed

+11
-52
lines changed

5 files changed

+11
-52
lines changed

build/gn_processor.py

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import tempfile
1111
from collections import defaultdict, deque
1212
from copy import deepcopy
13-
from importlib import util
1413
from pathlib import Path
1514
from shutil import which
1615

@@ -720,7 +719,6 @@ def generate_gn_config(
720719
input_variables,
721720
sandbox_variables,
722721
gn_target,
723-
preprocessor,
724722
moz_build_flag,
725723
):
726724
def str_for_arg(v):
@@ -775,25 +773,19 @@ def str_for_arg(v):
775773
subprocess.check_call(gen_args, cwd=build_root_dir, stderr=subprocess.STDOUT)
776774

777775
gn_config_file = resolved_tempdir / "project.json"
778-
if preprocessor:
779-
preprocessor.main(gn_config_file)
780-
781776
with open(gn_config_file) as fh:
782-
gn_out = json.load(fh)
783-
gn_out = filter_gn_config(
784-
resolved_tempdir, gn_out, sandbox_variables, input_variables, gn_target
777+
raw_json = fh.read()
778+
raw_json = raw_json.replace(f"{target_dir}/", "")
779+
raw_json = raw_json.replace(f"{target_dir}:", ":")
780+
gn_config = json.loads(raw_json)
781+
gn_config = filter_gn_config(
782+
resolved_tempdir,
783+
gn_config,
784+
sandbox_variables,
785+
input_variables,
786+
gn_target,
785787
)
786-
return gn_out
787-
788-
789-
def load_preprocessor(script_name):
790-
if script_name and os.path.isfile(script_name):
791-
print(f"Loading preprocessor {script_name}")
792-
spec = util.spec_from_file_location("preprocess", script_name)
793-
module = util.module_from_spec(spec)
794-
spec.loader.exec_module(module)
795-
return module
796-
return None
788+
return gn_config
797789

798790

799791
def main():
@@ -840,8 +832,6 @@ def main():
840832
vars["use_x11"] = True
841833
vars_set.append(vars)
842834

843-
preprocessor = load_preprocessor(config.get("preprocessing_script", None))
844-
845835
gn_configs = []
846836
for vars in vars_set:
847837
gn_configs.append(
@@ -852,7 +842,6 @@ def main():
852842
vars,
853843
config["gn_sandbox_variables"],
854844
config["gn_target"],
855-
preprocessor,
856845
config["moz_build_flag"],
857846
)
858847
)

dom/media/webrtc/third_party_build/gn-configs/abseil.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"build_root_dir": "third_party",
33
"target_dir": "abseil-cpp",
4-
"preprocessing_script": "dom/media/webrtc/third_party_build/gn-configs/abseil_preprocessor.py",
54
"moz_build_flag": "build_mozilla_absl",
65
"gn_target": "//:absl",
76
"gn_sandbox_variables": {

dom/media/webrtc/third_party_build/gn-configs/abseil_preprocessor.py

Lines changed: 0 additions & 14 deletions
This file was deleted.

dom/media/webrtc/third_party_build/gn-configs/webrtc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"build_root_dir": "third_party",
33
"target_dir": "libwebrtc",
4-
"preprocessing_script": "dom/media/webrtc/third_party_build/gn-configs/webrtc_preprocessor.py",
54
"moz_build_flag": "build_mozilla_webrtc",
65
"gn_target": "//:webrtc",
76
"gn_sandbox_variables": {

dom/media/webrtc/third_party_build/gn-configs/webrtc_preprocessor.py

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)