Backed out changeset f2fbfecc33d1 (bug 1724336) for causing mochitest failures at URLPreloader.h CLOSED TREE

marco-c · marco-c · commit 7438c55d60eb · 2023-05-01T00:38:13.000Z
UltraBlame original commit: 7dd2e5db976d861f69363f886bfabeabb8807962
diff --git a/js/xpconnect/loader/URLPreloader.h b/js/xpconnect/loader/URLPreloader.h
@@ -153,7 +153,6 @@ class URLPreloader final : public nsIMemoryReporter {
     explicit CacheKey(nsIFile* file) : mType(TypeFile) {
       nsString path;
       MOZ_ALWAYS_SUCCEEDS(file->GetPath(path));
-      MOZ_DIAGNOSTIC_ASSERT(path.Length() > 0);
       CopyUTF16toUTF8(path, mPath);
     }
 
@@ -163,7 +162,6 @@ class URLPreloader final : public nsIMemoryReporter {
     template <typename Buffer>
     void Code(Buffer& buffer) {
       buffer.codeUint8(*reinterpret_cast<uint8_t*>(&mType));
-      MOZ_DIAGNOSTIC_ASSERT(mPath.Length() > 0);
       buffer.codeString(mPath);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,6 @@ class URLPreloader final : public nsIMemoryReporter {`
`153`	`153`	`explicit CacheKey(nsIFile* file) : mType(TypeFile) {`
`154`	`154`	`nsString path;`
`155`	`155`	`MOZ_ALWAYS_SUCCEEDS(file->GetPath(path));`
`156`		`- MOZ_DIAGNOSTIC_ASSERT(path.Length() > 0);`
`157`	`156`	`CopyUTF16toUTF8(path, mPath);`
`158`	`157`	`}`
`159`	`158`
`@@ -163,7 +162,6 @@ class URLPreloader final : public nsIMemoryReporter {`
`163`	`162`	`template <typename Buffer>`
`164`	`163`	`void Code(Buffer& buffer) {`
`165`	`164`	`buffer.codeUint8(reinterpret_cast<uint8_t>(&mType));`
`166`		`- MOZ_DIAGNOSTIC_ASSERT(mPath.Length() > 0);`
`167`	`165`	`buffer.codeString(mPath);`
`168`	`166`	`}`
`169`	`167`