Bug 1966657: Only run shell jobs if JS_ExecuteScript returns true; r=iain

Differential Revision: https://phabricator.services.mozilla.com/D250193

UltraBlame original commit: 0cf73230aa697fae71a8aa6c5a52eb79d956c99e

Author: marco-c

js/src/jit-test/tests/atomics/bug1966657-promise-resolution-after-throw.js

@@ -0,0 +1,18 @@
+
+
+let sab = new SharedArrayBuffer(Int32Array.BYTES_PER_ELEMENT);
+setSharedObject(sab);
+
+evalInWorker(`
+  const i32 = new Int32Array(getSharedObject());
+  let p = new Promise((resolve) => resolve(3));
+  p.then(() => {
+    Atomics.store(i32, 0, 1);
+  });
+  throw "error";
+`);
+
+
+let i32 = new Int32Array(sab);
+while (Atomics.load(i32, 0) === 0) {}
+

js/src/jit-test/tests/atomics/bug1966657.js

@@ -0,0 +1,11 @@
+
+evalInWorker(`
+  a = {
+    then() {
+      b
+    }
+  }
+  Promise.any([a])
+  c
+`)
+

js/src/shell/js.cpp

@@ -4656,19 +4656,21 @@ static void WorkerMain(UniquePtr<WorkerInput> input) {
         .setIsRunOnce(true)
         .setEagerDelazificationStrategy(defaultDelazificationMode);
 
-    AutoReportException are(cx);
-    JS::SourceText<char16_t> srcBuf;
-    if (!srcBuf.init(cx, input->chars.get(), input->length,
-                     JS::SourceOwnership::Borrowed)) {
-      break;
-    }
+    {
+      AutoReportException are(cx);
+      JS::SourceText<char16_t> srcBuf;
+      if (!srcBuf.init(cx, input->chars.get(), input->length,
+                       JS::SourceOwnership::Borrowed)) {
+        break;
+      }
 
-    RootedScript script(cx, JS::Compile(cx, options, srcBuf));
-    if (!script) {
-      break;
+      RootedScript script(cx, JS::Compile(cx, options, srcBuf));
+      if (!script) {
+        break;
+      }
+      RootedValue result(cx);
+      JS_ExecuteScript(cx, script, &result);
     }
-    RootedValue result(cx);
-    JS_ExecuteScript(cx, script, &result);
 
     RunShellJobs(cx);
   } while (0);