Skip to content

Commit a6a2f55

Browse files
marco-cmarco-c
committed
Bug 1966725 [wpt PR 52569] - [gap-decorations] Avoid invalidating col rules when GapDecorations is on,
Automatic update from web-platform-tests [gap-decorations] Avoid invalidating col rules when GapDecorations is on This CL makes it so we avoid making a call to `ColumnRuleStyleDidChange()` in `LayoutBlockFlow::StyleDidChange()` so that we do not invalidate column rules when GapDecorations is enabled, since with GapDecorations we already invalidate via the `invalidate: paint` pipeline in `css_properties.json`. The test added in this CL makes sure we are still invalidating correctly after this change. Bug: 357648037 Change-Id: I93f1a453133e658bca88277d8e253075ce2e2cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532734 Reviewed-by: Alison Maher <almahermicrosoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org> Commit-Queue: Javier Contreras <javierconmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1460754} -- wpt-commits: 12048307995281f5e6cc9f3bcfb20d7b2877bd48 wpt-pr: 52569 Differential Revision: https://phabricator.services.mozilla.com/D250631 UltraBlame original commit: 112bba61ff7c12edcdc3b89949f77745ed98edb6
1 parent 3eaadc2 commit a6a2f55

File tree

2 files changed

+580
-0
lines changed

2 files changed

+580
-0
lines changed

‎testing/web-platform/tests/css/css-gaps/agnostic/gap-decorations-003-ref.html

Lines changed: 183 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,183 @@
1+
<
2+
!
3+
DOCTYPE
4+
html
5+
>
6+
<
7+
style
8+
>
9+
body
10+
{
11+
margin
12+
:
13+
0px
14+
;
15+
}
16+
#
17+
current
18+
{
19+
columns
20+
:
21+
6
22+
;
23+
column
24+
-
25+
gap
26+
:
27+
2px
28+
;
29+
column
30+
-
31+
rule
32+
-
33+
style
34+
:
35+
solid
36+
;
37+
column
38+
-
39+
rule
40+
-
41+
width
42+
:
43+
2px
44+
;
45+
column
46+
-
47+
fill
48+
:
49+
auto
50+
;
51+
height
52+
:
53+
20px
54+
;
55+
column
56+
-
57+
rule
58+
-
59+
color
60+
:
61+
hotpink
62+
;
63+
width
64+
:
65+
72px
66+
;
67+
height
68+
:
69+
20px
70+
;
71+
}
72+
.
73+
items
74+
{
75+
background
76+
-
77+
color
78+
:
79+
lightgreen
80+
;
81+
height
82+
:
83+
20px
84+
}
85+
<
86+
/
87+
style
88+
>
89+
<
90+
body
91+
>
92+
<
93+
div
94+
id
95+
=
96+
"
97+
current
98+
"
99+
>
100+
<
101+
div
102+
class
103+
=
104+
"
105+
items
106+
"
107+
>
108+
<
109+
/
110+
div
111+
>
112+
<
113+
div
114+
class
115+
=
116+
"
117+
items
118+
"
119+
>
120+
<
121+
/
122+
div
123+
>
124+
<
125+
div
126+
class
127+
=
128+
"
129+
items
130+
"
131+
>
132+
<
133+
/
134+
div
135+
>
136+
<
137+
div
138+
class
139+
=
140+
"
141+
items
142+
"
143+
>
144+
<
145+
/
146+
div
147+
>
148+
<
149+
div
150+
class
151+
=
152+
"
153+
items
154+
"
155+
>
156+
<
157+
/
158+
div
159+
>
160+
<
161+
div
162+
class
163+
=
164+
"
165+
items
166+
"
167+
>
168+
<
169+
/
170+
div
171+
>
172+
<
173+
/
174+
div
175+
>
176+
<
177+
/
178+
body
179+
>
180+
<
181+
/
182+
html
183+
>

0 commit comments

Comments
 (0)