Bug 1996291 - Rework getStatus to getStatusByEngineId and fix status reporting in about:inference r=firefox-ai-ml-reviewers,tarek

When going through the tests I could not figure out what this code did.
After some sleuthing I realized that it was gathering information for
the about:inference. However, the code was badly broken, and incorrect
in what it was doing. I simplified the implementation a bit, and fixed
the breakage in about:inference.

There are no tests for this behavior in about:inference, and there as
far as I can tell there are no live models in about:inference that could
be used to test this behavior. Since it's a developer-only facing
feature, I'm not planning on adding a test for it.

Also please note that I'm adding an ml.d.ts file here to centralize some
shared types. See the in-flight TypeScript documentation here:
https://phabricator.services.mozilla.com/D268571

Differential Revision: https://phabricator.services.mozilla.com/D269982

UltraBlame original commit: 90470f1361431a99abb4526828c12b7adc2296cb

Author: marco-c

toolkit/components/aboutinference/content/aboutInference.js

@@ -111,6 +111,53 @@ strict
 *
 *
 *
+import
+{
+MLEngineParent
+}
+from
+"
+resource
+:
+/
+/
+gre
+/
+actors
+/
+MLEngineParent
+.
+sys
+.
+mjs
+"
+*
+import
+{
+StatusByEngineId
+}
+from
+"
+.
+.
+/
+.
+.
+/
+ml
+/
+ml
+.
+d
+.
+ts
+"
+*
+/
+/
+*
+*
+*
 Imports
 necessary
 modules
@@ -557,6 +604,17 @@ i
 )
 ;
 }
+/
+*
+*
+type
+{
+MLEngineParent
+|
+null
+}
+*
+/
 let
 engineParent
 =
@@ -4209,17 +4267,44 @@ updateStatus
 (
 )
 {
+const
+engineParent
+=
+await
+getEngineParent
+(
+)
+;
 if
 (
 !
 engineParent
 )
 {
+/
+/
+The
+engine
+parent
+is
+not
+available
+.
 return
 ;
 }
+/
+*
+*
+*
+type
+{
+StatusByEngineId
+}
+*
+/
 let
-info
+statusByEngineId
 ;
 /
 /
@@ -4230,38 +4315,37 @@ status
 info
 try
 {
-info
+statusByEngineId
 =
 await
 engineParent
 .
-getStatus
+getStatusByEngineId
 (
 )
 ;
 }
 catch
 (
-e
+error
 )
 {
-engineParent
-=
-null
-;
-/
-/
-let
-'
-s
-re
--
-create
-it
-on
-errors
+console
 .
-info
+error
+(
+"
+Failed
+to
+get
+the
+engine
+status
+"
+error
+)
+;
+statusByEngineId
 =
 new
 Map
@@ -4304,7 +4388,7 @@ is
 empty
 if
 (
-info
+statusByEngineId
 .
 size
 =
@@ -4556,10 +4640,13 @@ for
 let
 [
 engineId
-engineInfo
+{
+status
+options
+}
 ]
 of
-info
+statusByEngineId
 .
 entries
 (
@@ -4629,8 +4716,6 @@ statusCell
 .
 textContent
 =
-engineInfo
-.
 status
 ;
 row
@@ -4656,8 +4741,6 @@ modelIdCell
 .
 textContent
 =
-engineInfo
-.
 options
 ?
 .
@@ -4693,8 +4776,6 @@ dtypeCell
 .
 textContent
 =
-engineInfo
-.
 options
 ?
 .
@@ -4730,8 +4811,6 @@ deviceCell
 .
 textContent
 =
-engineInfo
-.
 options
 ?
 .
@@ -4767,8 +4846,6 @@ timeoutCell
 .
 textContent
 =
-engineInfo
-.
 options
 ?
 .
@@ -8427,6 +8504,21 @@ true
 )
 ;
 }
+/
+*
+*
+*
+returns
+{
+Promise
+<
+MLEngineParent
+|
+null
+>
+}
+*
+/
 async
 function
 getEngineParent
@@ -8439,6 +8531,8 @@ if
 engineParent
 )
 {
+try
+{
 engineParent
 =
 await
@@ -8449,6 +8543,16 @@ getMLEngineParent
 )
 ;
 }
+catch
+(
+error
+)
+{
+return
+null
+;
+}
+}
 return
 engineParent
 ;

toolkit/components/aboutinference/tests/browser/browser.toml

@@ -12,6 +12,19 @@ head
 js
 "
 ]
+prefs
+=
+[
+"
+browser
+.
+ml
+.
+logLevel
+=
+Debug
+"
+]
 [
 "
 browser_aboutinference