Skip to content

Commit 57ac275

Browse files
committed
Bug 1966212 [wpt PR 52508] - Ability to check inline/float/OOF without LayoutObject bits.,
Automatic update from web-platform-tests Ability to check inline/float/OOF without LayoutObject bits. As pointed out in LayoutBox::IsValidColumnSpanner(), this function may be called at "inconvenient" times, also before StyleDidChange() has finished, so we cannot trust the LayoutObject bits for inline-level, float, or position. Add the ability to provide this information without checking those bits. The information we need is computed style and layout object type. It was possible for the function to return true for `column-span:all` and `float:left`, which is wrong. Bug: 417256483 Change-Id: Iaa8903a716a5f9a1d4cc18d42c48680e7fb2c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6540050 Commit-Queue: Morten Stenshorne <mstenshochromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrickchromium.org> Cr-Commit-Position: refs/heads/main{#1459638} -- wpt-commits: d5e6a87919e3c8d6c1b52348ff17c64bde2ff849 wpt-pr: 52508 Differential Revision: https://phabricator.services.mozilla.com/D250156 UltraBlame original commit: f86e2afb99463200acdde9b6f7845f229aa0a21d
1 parent dea3dec commit 57ac275

File tree

1 file changed

+123
-0
lines changed

1 file changed

+123
-0
lines changed
Lines changed: 123 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
1+
<
2+
!
3+
DOCTYPE
4+
html
5+
>
6+
<
7+
link
8+
rel
9+
=
10+
"
11+
author
12+
"
13+
title
14+
=
15+
"
16+
Morten
17+
Stenshorne
18+
"
19+
href
20+
=
21+
"
22+
mailto
23+
:
24+
mstensho
25+
chromium
26+
.
27+
org
28+
"
29+
>
30+
<
31+
link
32+
rel
33+
=
34+
"
35+
help
36+
"
37+
href
38+
=
39+
"
40+
https
41+
:
42+
/
43+
/
44+
issues
45+
.
46+
chromium
47+
.
48+
org
49+
/
50+
issues
51+
/
52+
417256483
53+
"
54+
>
55+
<
56+
div
57+
style
58+
=
59+
"
60+
columns
61+
:
62+
2
63+
;
64+
"
65+
>
66+
<
67+
div
68+
id
69+
=
70+
"
71+
e59
72+
"
73+
style
74+
=
75+
"
76+
float
77+
:
78+
left
79+
;
80+
width
81+
:
82+
100px
83+
;
84+
column
85+
-
86+
span
87+
:
88+
all
89+
;
90+
"
91+
>
92+
<
93+
/
94+
div
95+
>
96+
m
97+
<
98+
/
99+
div
100+
>
101+
<
102+
script
103+
>
104+
document
105+
.
106+
body
107+
.
108+
offsetTop
109+
;
110+
e59
111+
.
112+
style
113+
.
114+
width
115+
=
116+
"
117+
101px
118+
"
119+
;
120+
<
121+
/
122+
script
123+
>

0 commit comments

Comments
 (0)