Skip to content

Commit b84e89a

Browse files
committed
Bug 1949894 [wpt PR 50886] - Handle overlay scrollbars gracefully in auto-scrollbars.html, a=testonly
Automatic update from web-platform-tests Handle overlay scrollbars gracefully in auto-scrollbars.html The WPT test auto-scrollbars.html depends on the browser not having overlay scrollbars. This test has been consistently failing on mac due to failing this assertion: https://luci-milo.appspot.com/ui/tests/p/chromium/rules/751e05390273c6cfc8bf07cc5d245522?annotated=false&historyTimeRange=30d&selectedMetrics=human-cls-failed-presubmit%2Ccritical-failures-exonerated%2Cfailures%2Cbuilds-failed-due-to-flaky-tests&tab=recent-failures&groupBy=os This CL changes the file so that tests are skipped when overlay scrollbars are detected instead of crashing after failing the assertion. Crbug 398159676 was created as a follow up of this CL to make our infra handle assert_implements_optional as not failures. After that work is completed, this CL will be reverted and the assert will be restored. Bug: 398159676, 398159680 Change-Id: Ibe6efb7dce6528f6eb397a116ab45312e9edd5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6288285 Reviewed-by: Xianzhu Wang <wangxianzhuchromium.org> Commit-Queue: Gaston Rodriguez <gastonrmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1423390} -- wpt-commits: e5d62457ed30f84cda5ac3665e7de05604e8c1c2 wpt-pr: 50886 UltraBlame original commit: ccf2443496efb1b02d651d40d17df066eb6f3117
1 parent e44516f commit b84e89a

File tree

1 file changed

+21
-16
lines changed

1 file changed

+21
-16
lines changed

testing/web-platform/tests/css/css-conditional/container-queries/auto-scrollbars.html

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -288,26 +288,19 @@
288288
(
289289
)
290290
;
291-
assert_implements_optional
292-
(
291+
}
292+
)
293+
;
294+
const
295+
has_overlay_scrollbars
296+
=
293297
precondition
294298
.
295299
clientWidth
296-
<
300+
=
301+
=
302+
=
297303
100
298-
"
299-
Tests
300-
do
301-
not
302-
work
303-
with
304-
overlay
305-
scrollbars
306-
"
307-
)
308-
;
309-
}
310-
)
311304
;
312305
let
313306
initialScrollerWidth
@@ -323,6 +316,12 @@
323316
=
324317
>
325318
{
319+
if
320+
(
321+
has_overlay_scrollbars
322+
)
323+
return
324+
;
326325
assert_equals
327326
(
328327
getComputedStyle
@@ -375,6 +374,12 @@
375374
=
376375
>
377376
{
377+
if
378+
(
379+
has_overlay_scrollbars
380+
)
381+
return
382+
;
378383
inner
379384
.
380385
style

0 commit comments

Comments
 (0)