fix: nullable field empty

marcocesarato · marcocesarato · commit 8e2fdc1660ae · 2019-11-26T09:01:11.000+01:00
diff --git a/includes/classes/API.php b/includes/classes/API.php
@@ -1053,7 +1053,7 @@ private function patch($query, $db = null)
                         if (is_array($value)) {
                             $value = serialize($value);
                         }
-                        if (is_string($value) && strtolower($value) == 'null') {
+                        if (is_string($value) && strtolower($value) === 'null') {
                             $value = null;
                         }
                         $key = ':' . $key;
@@ -1069,9 +1069,6 @@ private function patch($query, $db = null)
                         foreach ($where_values as $key => $value) {
                             $key = ':' . $key;
                             $sql_compiled = self::debugCompileSQL($sql_compiled, $key, $value);
-                            if (empty($value)) {
-                                $value = null;
-                            }
                             $sth->bindValue($key, $value);
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -1053,7 +1053,7 @@ private function patch($query, $db = null)`
`1053`	`1053`	`if (is_array($value)) {`
`1054`	`1054`	`$value = serialize($value);`
`1055`	`1055`	`}`
`1056`		`- if (is_string($value) && strtolower($value) == 'null') {`
	`1056`	`+ if (is_string($value) && strtolower($value) === 'null') {`
`1057`	`1057`	`$value = null;`
`1058`	`1058`	`}`
`1059`	`1059`	`$key = ':' . $key;`
`@@ -1069,9 +1069,6 @@ private function patch($query, $db = null)`
`1069`	`1069`	`foreach ($where_values as $key => $value) {`
`1070`	`1070`	`$key = ':' . $key;`
`1071`	`1071`	`$sql_compiled = self::debugCompileSQL($sql_compiled, $key, $value);`
`1072`		`- if (empty($value)) {`
`1073`		`- $value = null;`
`1074`		`- }`
`1075`	`1072`	`$sth->bindValue($key, $value);`
`1076`	`1073`	`}`
`1077`	`1074`	`}`