RuboCop

marcoroth · marcoroth · commit 36ac97931105 · 2025-06-05T03:59:52.000+02:00
diff --git a/Gemfile b/Gemfile
@@ -15,7 +15,7 @@ gem "rake-compiler-dock", "~> 1.9"
 gem "rubocop", "~> 1.71"
 
 group :development do
-  gem "sorbet"
   gem "rbs-inline", require: false, github: "marcoroth/rbs-inline", branch: "prism"
+  gem "sorbet"
   gem "steep", "~> 1.10"
 end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -35,7 +35,7 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
+    ast (2.4.3)
     base64 (0.3.0)
     benchmark (0.4.1)
     bigdecimal (3.2.2)
@@ -56,19 +56,15 @@ GEM
     ffi (1.17.2)
     ffi (1.17.2-aarch64-linux-gnu)
     ffi (1.17.2-aarch64-linux-musl)
-    ffi (1.17.2-arm-linux-gnu)
-    ffi (1.17.2-arm-linux-musl)
     ffi (1.17.2-arm64-darwin)
-    ffi (1.17.2-x86-linux-gnu)
-    ffi (1.17.2-x86-linux-musl)
     ffi (1.17.2-x86_64-darwin)
     ffi (1.17.2-x86_64-linux-gnu)
     ffi (1.17.2-x86_64-linux-musl)
     fileutils (1.7.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     json (2.12.2)
-    language_server-protocol (3.17.0.4)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
@@ -81,8 +77,8 @@ GEM
     minitest-difftastic (0.2.1)
       difftastic (~> 0.6)
     mutex_m (0.3.0)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     pretty_please (0.2.0)
@@ -99,19 +95,20 @@ GEM
     rbs (3.9.4)
       logger
     regexp_parser (2.10.0)
-    rubocop (1.73.2)
+    rubocop (1.76.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.45.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
+    rubocop-ast (1.45.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     sorbet (0.5.12053)
@@ -149,12 +146,7 @@ GEM
 PLATFORMS
   aarch64-linux-gnu
   aarch64-linux-musl
-  arm-linux-gnu
-  arm-linux-musl
   arm64-darwin
-  ruby
-  x86-linux-gnu
-  x86-linux-musl
   x86_64-darwin
   x86_64-linux
   x86_64-linux-gnu
diff --git a/Steepfile b/Steepfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 target :lib do
   signature "sig"
 
diff --git a/lib/herb/ast/node.rb b/lib/herb/ast/node.rb
@@ -72,8 +72,8 @@ def inspect_array(array, item_name: "item", prefix: "    ")
       end
 
       #: (?Integer) -> String
-      def tree_inspect(indent = 0)
-        raise NotImplementedError.new
+      def tree_inspect(_indent = 0)
+        raise NotImplementedError
       end
     end
   end
diff --git a/lib/herb/cli.rb b/lib/herb/cli.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "optparse"
diff --git a/lib/herb/libherb.rb b/lib/herb/libherb.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "ffi"
diff --git a/lib/herb/libherb/array.rb b/lib/herb/libherb/array.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "forwardable"
diff --git a/lib/herb/libherb/ast_node.rb b/lib/herb/libherb/ast_node.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 module Herb
diff --git a/lib/herb/libherb/buffer.rb b/lib/herb/libherb/buffer.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 module Herb
diff --git a/lib/herb/libherb/extract_result.rb b/lib/herb/libherb/extract_result.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "forwardable"
diff --git a/lib/herb/libherb/lex_result.rb b/lib/herb/libherb/lex_result.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "forwardable"
diff --git a/lib/herb/libherb/libherb.rb b/lib/herb/libherb/libherb.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "herb/libherb/ast_node"
diff --git a/lib/herb/libherb/parse_result.rb b/lib/herb/libherb/parse_result.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "forwardable"
diff --git a/lib/herb/libherb/token.rb b/lib/herb/libherb/token.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 module Herb
diff --git a/lib/herb/project.rb b/lib/herb/project.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # typed: ignore
+
 # rbs_inline: disabled
 
 require "io/console"
diff --git a/templates/lib/herb/errors.rb.erb b/templates/lib/herb/errors.rb.erb
@@ -38,8 +38,8 @@ module Herb
       end
 
       #: (?Integer) -> String
-      def tree_inspect(indent = 0)
-        raise NotImplementedError.new
+      def tree_inspect(_indent = 0)
+        raise NotImplementedError
       end
     end
 
diff --git a/templates/template.rb b/templates/template.rb
@@ -195,9 +195,7 @@ def normalize_kind(kind, type, name, field_name)
         if kind
           kind = [kind] unless kind.is_a?(Array)
 
-          if kind.size == 1
-            kind = kind.first
-          end
+          kind = kind.first if kind.size == 1
         elsif type < NodeField
           raise "Missing kind in config.yml for field #{name}##{field_name}"
         end
@@ -284,7 +282,7 @@ class PrintfMessageTemplate
         "%llu" => 20, # Large enough for long long unsigned
         "%ld" => 20, # Large enough for long int
         "%f" => 32,  # Floating point with precision
-        "%lf" => 32  # Long double
+        "%lf" => 32, # Long double
       }.freeze
 
       def self.estimate_buffer_size(template)

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`target :lib do`
`2`	`4`	`signature "sig"`
`3`	`5`