Parser: Transform Action View tag helpers inside control flow blocks (#1447)

This pull request fixes a bug in the `action_view_helpers` parser
analysis where tag helpers inside control flow blocks were not being
transformed into `HTMLElementNode` AST representations. They remained as
`ERBContentNode`, making them invisible to consumers relying on the
transformed AST.

For example, the following template with `action_view_helpers: true`:

```erb
<% if condition? %>
  <%= tag.img src: "/image.png", alt: "Photo" %>
<% end %>
```

  Previously produced:
```js
  @ ERBIfNode (location: (1:0)-(3:9))
  ├── statements: (1 item)
  │   └── @ ERBContentNode (location: (2:2)-(2:48))
  │       ├── tag_opening: "<%=" (location: (2:2)-(2:5))
  │       ├── content: " tag.img src: \"/image.png\", alt: \"Photo\" " (location: (2:5)-(2:46))
  │       └── tag_closing: "%>" (location: (2:46)-(2:48))
```

Now correctly produces:
```js
  @ ERBIfNode (location: (1:0)-(3:9))
  ├── statements: (1 item)
  │   └── @ HTMLElementNode (location: (2:2)-(2:48))
  │       ├── open_tag:
  │       │   └── @ ERBOpenTagNode (location: (2:2)-(2:48))
  │       │       ├── tag_opening: "<%=" (location: (2:2)-(2:5))
  │       │       ├── content: " tag.img src: \"/image.png\", alt: \"Photo\" " (location: (2:5)-(2:46))
  │       │       ├── tag_closing: "%>" (location: (2:46)-(2:48))
  │       │       ├── tag_name: "img" (location: (2:10)-(2:13))
  │       │       └── children: (2 items)
  │       │           ├── @ HTMLAttributeNode (name: "src", value: "/image.png")
  │       │           └── @ HTMLAttributeNode (name: "alt", value: "Photo")
  │       │
  │       ├── tag_name: "img" (location: (2:10)-(2:13))
  │       ├── body: []
  │       ├── close_tag: ∅
  │       ├── is_void: true
  │       └── element_source: "ActionView::Helpers::TagHelper#tag"
```

Author: marcoroth

src/analyze/action_view/tag_helpers.c

@@ -1062,21 +1062,8 @@ static AST_NODE_T* transform_link_to_helper(
   return (AST_NODE_T*) element;
 }
 
-void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T* context) {
-  if (!node || !context) { return; }
-
-  hb_array_T* array = NULL;
-
-  switch (node->type) {
-    case AST_DOCUMENT_NODE: array = ((AST_DOCUMENT_NODE_T*) node)->children; break;
-    case AST_HTML_ELEMENT_NODE: array = ((AST_HTML_ELEMENT_NODE_T*) node)->body; break;
-    case AST_HTML_OPEN_TAG_NODE: array = ((AST_HTML_OPEN_TAG_NODE_T*) node)->children; break;
-    case AST_HTML_ATTRIBUTE_VALUE_NODE: array = ((AST_HTML_ATTRIBUTE_VALUE_NODE_T*) node)->children; break;
-    case AST_ERB_BLOCK_NODE: array = ((AST_ERB_BLOCK_NODE_T*) node)->body; break;
-    default: return;
-  }
-
-  if (!array) { return; }
+void transform_tag_helper_array(hb_array_T* array, analyze_ruby_context_T* context) {
+  if (!array || !context) { return; }
 
   for (size_t i = 0; i < hb_array_size(array); i++) {
     AST_NODE_T* child = hb_array_get(array, i);
@@ -1231,6 +1218,45 @@ void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T*
   }
 }
 
+void transform_tag_helper_blocks(const AST_NODE_T* node, analyze_ruby_context_T* context) {
+  if (!node || !context) { return; }
+
+  switch (node->type) {
+    case AST_DOCUMENT_NODE: transform_tag_helper_array(((AST_DOCUMENT_NODE_T*) node)->children, context); break;
+    case AST_HTML_ELEMENT_NODE: transform_tag_helper_array(((AST_HTML_ELEMENT_NODE_T*) node)->body, context); break;
+    case AST_HTML_CONDITIONAL_ELEMENT_NODE:
+      transform_tag_helper_array(((AST_HTML_CONDITIONAL_ELEMENT_NODE_T*) node)->body, context);
+      break;
+    case AST_HTML_OPEN_TAG_NODE:
+      transform_tag_helper_array(((AST_HTML_OPEN_TAG_NODE_T*) node)->children, context);
+      break;
+    case AST_HTML_ATTRIBUTE_VALUE_NODE:
+      transform_tag_helper_array(((AST_HTML_ATTRIBUTE_VALUE_NODE_T*) node)->children, context);
+      break;
+    case AST_ERB_BLOCK_NODE: transform_tag_helper_array(((AST_ERB_BLOCK_NODE_T*) node)->body, context); break;
+    case AST_ERB_IF_NODE: transform_tag_helper_array(((AST_ERB_IF_NODE_T*) node)->statements, context); break;
+    case AST_ERB_ELSE_NODE: transform_tag_helper_array(((AST_ERB_ELSE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_UNLESS_NODE: transform_tag_helper_array(((AST_ERB_UNLESS_NODE_T*) node)->statements, context); break;
+    case AST_ERB_CASE_NODE:
+      transform_tag_helper_array(((AST_ERB_CASE_NODE_T*) node)->children, context);
+      transform_tag_helper_array(((AST_ERB_CASE_NODE_T*) node)->conditions, context);
+      break;
+    case AST_ERB_CASE_MATCH_NODE:
+      transform_tag_helper_array(((AST_ERB_CASE_MATCH_NODE_T*) node)->children, context);
+      transform_tag_helper_array(((AST_ERB_CASE_MATCH_NODE_T*) node)->conditions, context);
+      break;
+    case AST_ERB_WHEN_NODE: transform_tag_helper_array(((AST_ERB_WHEN_NODE_T*) node)->statements, context); break;
+    case AST_ERB_WHILE_NODE: transform_tag_helper_array(((AST_ERB_WHILE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_UNTIL_NODE: transform_tag_helper_array(((AST_ERB_UNTIL_NODE_T*) node)->statements, context); break;
+    case AST_ERB_FOR_NODE: transform_tag_helper_array(((AST_ERB_FOR_NODE_T*) node)->statements, context); break;
+    case AST_ERB_BEGIN_NODE: transform_tag_helper_array(((AST_ERB_BEGIN_NODE_T*) node)->statements, context); break;
+    case AST_ERB_RESCUE_NODE: transform_tag_helper_array(((AST_ERB_RESCUE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_ENSURE_NODE: transform_tag_helper_array(((AST_ERB_ENSURE_NODE_T*) node)->statements, context); break;
+    case AST_ERB_IN_NODE: transform_tag_helper_array(((AST_ERB_IN_NODE_T*) node)->statements, context); break;
+    default: break;
+  }
+}
+
 bool transform_tag_helper_nodes(const AST_NODE_T* node, void* data) {
   analyze_ruby_context_T* context = (analyze_ruby_context_T*) data;
 

test/analyze/action_view/tag_helper/tag_test.rb

@@ -279,5 +279,60 @@ class TagTest < Minitest::Spec
       assert_parsed_snapshot(template, action_view_helpers: true)
       assert_parsed_snapshot(template)
     end
+
+    test "tag.div inside if block" do
+      assert_parsed_snapshot(<<~HTML, action_view_helpers: true)
+        <% if condition? %>
+          <%= tag.div id: "my-id" do %>
+            Content
+          <% end %>
+        <% end %>
+      HTML
+    end
+
+    test "tag.img inside if block" do
+      assert_parsed_snapshot(<<~HTML, action_view_helpers: true)
+        <% if condition? %>
+          <%= tag.img src: "/image.png", alt: "Photo" %>
+        <% end %>
+      HTML
+    end
+
+    test "tag.div inside if/else branches" do
+      assert_parsed_snapshot(<<~HTML, action_view_helpers: true)
+        <% if condition? %>
+          <%= tag.div id: "my-id" do %>
+            Branch one
+          <% end %>
+        <% else %>
+          <%= tag.span id: "my-id" do %>
+            Branch two
+          <% end %>
+        <% end %>
+      HTML
+    end
+
+    test "tag.div inside case/when branches" do
+      assert_parsed_snapshot(<<~HTML, action_view_helpers: true)
+        <% case status %>
+        <% when "active" %>
+          <%= tag.div class: "active" do %>
+            Active
+          <% end %>
+        <% when "inactive" %>
+          <%= tag.div class: "inactive" do %>
+            Inactive
+          <% end %>
+        <% end %>
+      HTML
+    end
+
+    test "tag.img inside each loop" do
+      assert_parsed_snapshot(<<~HTML, action_view_helpers: true)
+        <% @items.each do |item| %>
+          <%= tag.img src: item.image_url, alt: item.name %>
+        <% end %>
+      HTML
+    end
   end
 end