Skip to content

Commit 5e6dcd6

Browse files
authored
Drop Ruby 3.1 support (#7)
Ruby 3.1 EOL ended 5 months ago and it's been causing trouble in CI, since Rails 8 depends on Ruby >= 3.2.
1 parent c1ae42b commit 5e6dcd6

File tree

5 files changed

+5
-7
lines changed

5 files changed

+5
-7
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ jobs:
1414
strategy:
1515
matrix:
1616
ruby:
17-
- '3.1'
1817
- '3.2'
1918
- '3.3'
2019
- '3.4'

.rubocop.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
AllCops:
22
NewCops: enable
33
SuggestExtensions: false
4-
TargetRubyVersion: 3.1
4+
TargetRubyVersion: 3.2
55
Exclude:
66
- node_modules/**/*
7+
- vendor/**/*
78

89
Style/StringLiterals:
910
Enabled: true

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ gemspec
77
gem "actionview", "~> 8.0"
88
# gem "herb", path: "../herb"
99
gem "maxitest"
10-
gem "minitest-difftastic"
1110
gem "minitest", "~> 5.16"
11+
gem "minitest-difftastic"
1212
gem "railties", "~> 8.0"
1313
gem "rake", "~> 13.0"
1414
gem "rubocop", "~> 1.80.1"

lib/reactionview/railtie.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ class Railtie < Rails::Railtie
1818

1919
config.after_initialize do
2020
ActiveSupport.on_load(:action_view) do
21-
if ReActionView.config.intercept_erb
22-
ActionView::Template.register_template_handler :erb, ReActionView::Template::Handlers::Herb
23-
end
21+
ActionView::Template.register_template_handler :erb, ReActionView::Template::Handlers::Herb if ReActionView.config.intercept_erb
2422
end
2523
end
2624
end

reactionview.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
1111
spec.summary = "An ActionView-compatible ERB engine with modern DX - re-imagined with Herb."
1212
spec.description = spec.summary
1313
spec.homepage = "https://reactionview.dev"
14-
spec.required_ruby_version = ">= 3.0.0"
14+
spec.required_ruby_version = ">= 3.2.0"
1515

1616
spec.metadata["homepage_uri"] = spec.homepage
1717
spec.metadata["source_code_uri"] = "https://github.com/marcoroth/reactionview"

0 commit comments

Comments
 (0)