Skip to content

HTML error is not displayed if it happens in layout template #68

@janko

Description

@janko

When I forgot to close the HTML tag, ReactionView / Herb Engine appears to skip rendering that HTML+ERB template entirely. This leads to Herb's error modal not being displayed in case the HTML error occurred in a layout file, as then <body> and <head> are entirely empty, which I imagine causes the Herb rendering issues (probably Herb is missing its CSS/JS).

Not sure if it was the original goal, but would it be possible to make Herb engine fault tolerant? In the sense that it would still render the unclosed tag, but return errors that ReactionView would display.

Or make HTML errors actual ruby errors that show up in a Rails error page or Better Errors? Not sure if it's possible to display the error well enough without having the control of a custom error modal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions