Issue #3 was fixed

Author: marcoscgdev

.idea/gradle.xml

@@ -12,15 +12,16 @@ protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_main);
         RateDialog.init(this); // Shows the dialog each 3 days and each 7 launches (default config)
-        //RateDialog.init(this, 2, RateDialog.DEFAULT_LAUNCHES_UNTIL_PROMPT);  // Shows the dialog with custom config.
+//        RateDialog.init(this, 2, RateDialog.DEFAULT_LAUNCHES_UNTIL_PROMPT);  // Shows the dialog with custom config.
 
         // Custom dialog instance
-//        RateDialog rateDialog = new RateDialog(this, "custom_rate_dialog");
+//        RateDialog rateDialog = new RateDialog(this, "custom_rate_dialog", 0 , 3);
 //        rateDialog.init();
     }
 
     public void openRateDialog (View v) {
-        RateDialog.showDialog(this); // Shows the dialog instantly
+        RateDialog rateDialog = new RateDialog(this, "custom_rate_dialog_key");
+        rateDialog.showDialog();
     }
 
 }

app/src/main/java/com/marcoscg/ratedialogsample/MainActivity.java

@@ -5,11 +5,11 @@
 import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.SharedPreferences;
+import android.content.res.Resources;
 import android.graphics.Typeface;
 import android.net.Uri;
 import android.os.Build;
 import android.support.v7.app.AlertDialog;
-import android.util.DisplayMetrics;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.widget.Button;
@@ -20,12 +20,12 @@ public class RateDialog {
 
     public static int DEFAULT_DAYS_UNTIL_PROMPT = 3;
     public static int DEFAULT_LAUNCHES_UNTIL_PROMPT = 7;
-    private static String DEFAULT_DIALOG_KEY = "ratedialog";
+    private static String DEFAULT_DIALOG_KEY = "default_rate_dialog_key";
 
     private Activity activity;
+    private AlertDialog alertDialog;
     private SharedPreferences prefs;
 
-    private String dialogKey;
     private int daysUntilPrompt;
     private int launchesUntilPrompt;
 
@@ -39,11 +39,12 @@ public RateDialog(Activity activity) {
 
     public RateDialog(Activity activity, String dialogKey, int daysUntilPrompt, int launchesUntilPrompt) {
         this.activity = activity;
-        this.dialogKey = dialogKey;
         this.daysUntilPrompt = daysUntilPrompt;
         this.launchesUntilPrompt = launchesUntilPrompt;
 
-        prefs = activity.getSharedPreferences(dialogKey, Context.MODE_PRIVATE);
+        prefs = activity.getSharedPreferences(dialogKey + "_rdp", Context.MODE_PRIVATE);
+
+        setupDialog();
     }
 
     public RateDialog(Activity activity, int daysUntilPrompt, int launchesUntilPrompt) {
@@ -96,26 +97,43 @@ public static void showDialog(Activity activity) {
      * Public methods
      */
     public void init() {
-        if (prefs == null || prefs.getBoolean(dialogKey + "dontshowagain", false)) { return; }
+        if (prefs == null || prefs.getBoolean("do_not_show_again", false)) {
+            return;
+        }
 
-        long launch_count = prefs.getLong(dialogKey + "launch_count", 0) + 1;
-        prefs.edit().putLong(dialogKey + "launch_count", launch_count).apply();
+        long launchCount = prefs.getLong("launch_count", 0) + 1;
+        prefs.edit().putLong("launch_count", launchCount).apply();
 
-        long date_firstLaunch = prefs.getLong(dialogKey + "date_firstlaunch", 0);
-        if (date_firstLaunch == 0) {
-            date_firstLaunch = System.currentTimeMillis();
-            prefs.edit().putLong(dialogKey + "date_firstlaunch", date_firstLaunch).apply();
+        long dateFirstLaunch = prefs.getLong("date_first_launch", 0);
+        if (dateFirstLaunch == 0) {
+            dateFirstLaunch = System.currentTimeMillis();
+            prefs.edit().putLong("date_first_launch", dateFirstLaunch).apply();
         }
 
-        if (launch_count >= launchesUntilPrompt) {
-            if (System.currentTimeMillis() >= date_firstLaunch +
+        if (launchCount >= launchesUntilPrompt) {
+            if (System.currentTimeMillis() >= dateFirstLaunch +
                     (daysUntilPrompt * 24 * 60 * 60 * 1000)) {
-                show(activity);
+                showDialog();
             }
         }
     }
 
     public void showDialog() {
+        if (alertDialog != null) {
+            alertDialog.show();
+        }
+    }
+
+    /**
+     * Private methods
+     */
+    private void neverShow() {
+        if (prefs != null) {
+            prefs.edit().putBoolean("do_not_show_again", true).apply();
+        }
+    }
+
+    private void setupDialog() {
         LayoutInflater inflater = activity.getLayoutInflater();
         View view = inflater.inflate(R.layout.dialog_layout, null);
 
@@ -125,7 +143,7 @@ public void showDialog() {
         title.setText(String.format(activity.getResources().getString(R.string.rate_dialog_title), activity.getResources().getString(R.string.app_name)));
         message.setText(activity.getString(R.string.rate_dialog_message, activity.getResources().getString(R.string.app_name)));
 
-        AlertDialog dialog = new AlertDialog.Builder(activity)
+        alertDialog = new AlertDialog.Builder(activity)
                 .setView(view)
                 .setPositiveButton(activity.getResources().getString(R.string.rate_dialog_action_rate), new DialogInterface.OnClickListener() {
                     public void onClick(DialogInterface dialog, int which) {
@@ -134,6 +152,7 @@ public void onClick(DialogInterface dialog, int which) {
                         } catch (android.content.ActivityNotFoundException anfe) {
                             activity.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("https://play.google.com/store/apps/details?id=" + activity.getPackageName())));
                         }
+
                         neverShow();
                         Toast.makeText(activity, activity.getResources().getString(R.string.rate_dialog_thank_you), Toast.LENGTH_SHORT).show();
                     }
@@ -144,39 +163,30 @@ public void onClick(DialogInterface dialog, int which) {
                         neverShow();
                     }
                 })
-                .show();
-
-        Typeface tf = Typeface.createFromAsset(activity.getAssets(),
-                "medium.ttf");
-
-        Button positivebt = dialog.getButton(AlertDialog.BUTTON_POSITIVE);
-        Button neutralbt = dialog.getButton(AlertDialog.BUTTON_NEUTRAL);
-        Button negativebt = dialog.getButton(AlertDialog.BUTTON_NEGATIVE);
-
-        positivebt.setPadding(dpToPx(12, activity),0,dpToPx(12, activity),0);
-        positivebt.setTypeface(tf);
-
-        neutralbt.setPadding(dpToPx(12, activity),0,dpToPx(12, activity),0);
-        neutralbt.setTypeface(tf);
-
-        negativebt.setPadding(dpToPx(12, activity),0,dpToPx(12, activity),0);
-        negativebt.setTypeface(tf);
+                .create();
+
+        alertDialog.setOnShowListener(new DialogInterface.OnShowListener() {
+            @Override
+            public void onShow(DialogInterface dialog) {
+                setButtonStyle(alertDialog.getButton(AlertDialog.BUTTON_POSITIVE));
+                setButtonStyle(alertDialog.getButton(AlertDialog.BUTTON_NEUTRAL));
+                setButtonStyle(alertDialog.getButton(AlertDialog.BUTTON_NEGATIVE));
+            }
+        });
     }
 
-    /**
-     * Private methods
-     */
-    private void neverShow() {
-        if (prefs != null) {
-            prefs.edit().putBoolean(dialogKey + "dontshowagain", true).apply();
+    private void setButtonStyle(Button button) {
+        if (Build.VERSION.SDK_INT >= 21) {
+            button.setPadding(dpToPx(14),0, dpToPx(14),0);
+        } else {
+            button.setPadding(dpToPx(12),0, dpToPx(12),0);
         }
+
+        button.setTypeface(Typeface.createFromAsset(activity.getAssets(), "medium.ttf"));
     }
 
-    private static int dpToPx(int dp, Activity activity) {
-        if (Build.VERSION.SDK_INT >= 21)
-            dp = dp+2;
-        DisplayMetrics displayMetrics = activity.getResources().getDisplayMetrics();
-        return Math.round(dp * (displayMetrics.xdpi / DisplayMetrics.DENSITY_DEFAULT));
+    private int dpToPx(int dp) {
+        return (int) (dp * Resources.getSystem().getDisplayMetrics().density);
     }
 
 }