Backport lexbor/lexbor#274

ndossche · ndossche · commit 42ad1c64bf0b · 2025-05-04T12:57:54.000+02:00
Co-authored-by: Alex Peattie <alexpeattie@gmail.com> Closes phpGH-18490.
diff --git a/NEWS b/NEWS
@@ -14,6 +14,9 @@ PHP                                                                        NEWS
   . Fixed bug GH-18481 (date_sunrise with unexpected nan value for the offset).
     (nielsdos/David Carlier)
 
+- DOM:
+  . Backport lexbor/lexbor#274. (nielsdos, alexpeattie)
+
 - Intl:
   . Fix various reference issues. (nielsdos)
 
diff --git a/ext/dom/lexbor/lexbor/selectors-adapted/selectors.c b/ext/dom/lexbor/lexbor/selectors-adapted/selectors.c
@@ -3,7 +3,7 @@
  *
  * Author: Alexander Borisov <borisov@lexbor.com>
  * Adapted for PHP + libxml2 by: Niels Dossche <nielsdos@php.net>
- * Based on Lexbor 2.4.0 (upstream commit e9d35f6384de7bd8c1b79e7111bc3a44f8822967)
+ * Based on Lexbor (upstream commit b347aa4e4da4e82b1cae18989ceea1aa0278daf1)
  */
 
 #include <libxml/xmlstring.h>
@@ -970,7 +970,7 @@ lxb_selectors_state_has_relative(const xmlNode *node,
 			break;
 		}
 
-		while (node !=root && node->next == NULL) {
+		while (node != root && node->next == NULL && node->parent != NULL) {
 			node = node->parent;
 		}
 
diff --git a/ext/dom/tests/modern/css_selectors/lexbor274.phpt b/ext/dom/tests/modern/css_selectors/lexbor274.phpt
@@ -0,0 +1,13 @@
+--TEST--
+Lexbor #274
+--EXTENSIONS--
+dom
+--FILE--
+<?php
+
+$dom = Dom\HTMLDocument::createFromString('<html><body><div></div>\n</body></html>', LIBXML_NOERROR);
+var_dump($dom->querySelector('a:has(+ b)'));
+
+?>
+--EXPECT--
+NULL

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Author: Alexander Borisov <[email protected]>`
`5`	`5`	`* Adapted for PHP + libxml2 by: Niels Dossche <[email protected]>`
`6`		`- * Based on Lexbor 2.4.0 (upstream commit e9d35f6384de7bd8c1b79e7111bc3a44f8822967)`
	`6`	`+ * Based on Lexbor (upstream commit b347aa4e4da4e82b1cae18989ceea1aa0278daf1)`
`7`	`7`	`*/`
`8`	`8`
`9`	`9`	`#include <libxml/xmlstring.h>`
`@@ -970,7 +970,7 @@ lxb_selectors_state_has_relative(const xmlNode *node,`
`970`	`970`	`break;`
`971`	`971`	`}`
`972`	`972`
`973`		`- while (node !=root && node->next == NULL) {`
	`973`	`+ while (node != root && node->next == NULL && node->parent != NULL) {`
`974`	`974`	`node = node->parent;`
`975`	`975`	`}`
`976`	`976`