-
Notifications
You must be signed in to change notification settings - Fork 18
Description
Hey Marcus, thank you for creating nightshift! I used it for the first time today on my project inspire-rs and it generated 6 PRs overnight covering clippy fixes, rustdoc warnings, changelog cleanup, and commit linting. Really love the "worst case you close the PR" philosophy.
One thing I noticed is that the generated PRs sometimes have issues that could be caught before they even land on GitHub. roborev is a tool that does continuous code review on every commit using the same coding agents nightshift already supports (Claude Code, Codex). It runs locally via git hooks and can auto-fix findings with roborev fix / roborev refine.
The idea: nightshift could run roborev review (and optionally roborev refine) on the commits it generates before pushing the branch and opening the PR. This would mean PRs arrive already passing a review pass, leading to higher-quality suggestions and fewer PRs that need to be closed due to trivial issues.
A possible integration could look like:
- After nightshift generates commits on a branch, trigger roborev fix or roborev refine to iterate until reviews pass (I have a git hook on commits)
- Only push and open the PR once roborev gives a green status
- Make it opt-in via config, e.g. review.provider: roborev
This feels like a natural pairing: nightshift finds what you forgot to look for, and roborev makes sure the fix is solid before it reaches your PR queue.
Wdyt?