Skip to content

Commit 3c92f1b

Browse files
authored
Fixed urlParameters that didn't show up with value false (#17)
* Fixed urlParameters that didn't show up with value false * Changelog * Fix
1 parent 230e9cf commit 3c92f1b

File tree

7 files changed

+21
-7
lines changed

7 files changed

+21
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 0.1.5
2+
- Fixed `urlParameters` which has a value of `false` or `0` but didn't show up
3+
- Added ability to have a custom baseUrl - thanks to @sabinayakc
4+
15
# 0.1.4
26
- Updated supported `ui` themes
37

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-drawio",
3-
"version": "0.1.4",
3+
"version": "0.1.5",
44
"type": "module",
55
"description": "React component for integrating the Diagrams (draw.io) embed iframe",
66
"main": "index.js",

src/DrawIoEmbed.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export const DrawIoEmbed = forwardRef<DrawIoEmbedRef, DrawIoEmbedProps>(
106106
onTemplate(data);
107107
}
108108
}
109-
});
109+
}, baseUrl);
110110
};
111111

112112
useImperativeHandle(

src/utils/getEmbedUrl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const getEmbedUrl = (
1818
Object.keys(urlParameters).forEach((key) => {
1919
const value = urlParameters[key as keyof UrlParameters];
2020

21-
if (value) {
21+
if (value !== undefined) {
2222
if (typeof value === 'boolean') {
2323
urlSearchParams.append(key, value ? '1' : '0');
2424
} else {

src/utils/handleEvent.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ type EventHandler = {
44
[key in EmbedEvents['event']]?: (data: Extract<EmbedEvents, { event: key }>) => void;
55
};
66

7-
export function handleEvent(event: MessageEvent, handlers: EventHandler) {
8-
if (!event.origin.includes('embed.diagrams.net') && !event.origin.includes(baseUrl)) {
7+
export function handleEvent(event: MessageEvent, handlers: EventHandler, baseUrl?: string) {
8+
if (!event.origin.includes('embed.diagrams.net') && (baseUrl && !event.origin.includes(baseUrl))) {
99
return;
1010
}
1111

stories/DiagramsEmbed.stories.tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,3 +297,13 @@ export const ExportData: Story = {
297297
}
298298
]
299299
};
300+
301+
export const NoSaveAndExit: Story = {
302+
args: {
303+
urlParameters: {
304+
saveAndExit: false,
305+
noExitBtn: true,
306+
noSaveBtn: true
307+
}
308+
}
309+
};

0 commit comments

Comments
 (0)