Skip to content

Commit fa4ea48

Browse files
committed
Don't reuse the same variable with different types
1 parent 8c5aff4 commit fa4ea48

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

src/labelle/gui/q_labels_list.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -215,35 +215,35 @@ def contextMenuEvent(self, event) -> None:
215215

216216
if menu_click == add_text:
217217
item = QListWidgetItem(self)
218-
item_widget = TextDymoLabelWidget(self.render_context)
219-
item.setSizeHint(item_widget.sizeHint())
218+
text_item_widget = TextDymoLabelWidget(self.render_context)
219+
item.setSizeHint(text_item_widget.sizeHint())
220220
self.addItem(item)
221-
self.setItemWidget(item, item_widget)
222-
item_widget.itemRenderSignal.connect(self.render_label)
221+
self.setItemWidget(item, text_item_widget)
222+
text_item_widget.itemRenderSignal.connect(self.render_label)
223223

224224
if menu_click == add_qr:
225225
item = QListWidgetItem(self)
226-
item_widget = QrDymoLabelWidget(self.render_context)
227-
item.setSizeHint(item_widget.sizeHint())
226+
qr_item_widget = QrDymoLabelWidget(self.render_context)
227+
item.setSizeHint(qr_item_widget.sizeHint())
228228
self.addItem(item)
229-
self.setItemWidget(item, item_widget)
230-
item_widget.itemRenderSignal.connect(self.render_label)
229+
self.setItemWidget(item, qr_item_widget)
230+
qr_item_widget.itemRenderSignal.connect(self.render_label)
231231

232232
if menu_click == add_barcode:
233233
item = QListWidgetItem(self)
234-
item_widget = BarcodeDymoLabelWidget(self.render_context)
235-
item.setSizeHint(item_widget.sizeHint())
234+
barcode_item_widget = BarcodeDymoLabelWidget(self.render_context)
235+
item.setSizeHint(barcode_item_widget.sizeHint())
236236
self.addItem(item)
237-
self.setItemWidget(item, item_widget)
238-
item_widget.itemRenderSignal.connect(self.render_label)
237+
self.setItemWidget(item, barcode_item_widget)
238+
barcode_item_widget.itemRenderSignal.connect(self.render_label)
239239

240240
if menu_click == add_img:
241241
item = QListWidgetItem(self)
242-
item_widget = ImageDymoLabelWidget(self.render_context)
243-
item.setSizeHint(item_widget.sizeHint())
242+
image_item_widget = ImageDymoLabelWidget(self.render_context)
243+
item.setSizeHint(image_item_widget.sizeHint())
244244
self.addItem(item)
245-
self.setItemWidget(item, item_widget)
246-
item_widget.itemRenderSignal.connect(self.render_label)
245+
self.setItemWidget(item, image_item_widget)
246+
image_item_widget.itemRenderSignal.connect(self.render_label)
247247
if menu_click == delete:
248248
try:
249249
item_to_delete = self.itemAt(event.pos())

0 commit comments

Comments
 (0)