fix: toArray

Author: renanmav

cpp/MGBigNumberHostObject.cpp

@@ -95,14 +95,35 @@ namespace margelo
             {
                 len = std::max(1, numberLen);
             }
+            else
+            {
+                len = std::min(len, numberLen);
+            }
+
             unsigned char *to = new unsigned char[len];
             if (le)
             {
-                BN_bn2lebinpad(thiz->bign, to, len);
+                if (len == numberLen) {
+                    BN_bn2lebinpad(thiz->bign, to, len);
+                } else {
+                    // For smaller lengths, we need to get the full number and truncate
+                    unsigned char *full = new unsigned char[numberLen];
+                    BN_bn2lebinpad(thiz->bign, full, numberLen);
+                    memcpy(to, full, len);
+                    delete[] full;
+                }
             }
             else
             {
-                BN_bn2binpad(thiz->bign, to, len);
+                if (len == numberLen) {
+                    BN_bn2binpad(thiz->bign, to, len);
+                } else {
+                    // For smaller lengths, we need to get the full number and truncate
+                    unsigned char *full = new unsigned char[numberLen];
+                    BN_bn2binpad(thiz->bign, full, numberLen);
+                    memcpy(to, full, len);
+                    delete[] full;
+                }
             }
 
             jsi::Array res(runtime, len);

example/src/Testing/TestList.ts

@@ -9,8 +9,6 @@ import BN from 'react-native-bignumber';
 import { describe, it } from './MochaRNAdapter';
 import chai from 'chai';
 
-console.log('BN', BN);
-
 export const TEST_LIST: Array<TestItemType> = [
   {
     description: 'SimpleTests',
@@ -40,7 +38,7 @@ export const TEST_LIST: Array<TestItemType> = [
 
         it('basic toArray', () => {
           chai.assert.deepEqual(
-            new BN([1, 2, 3, 4], 'hex', 'le').toArray('le', 3),
+            new BN([1, 2, 3, 4], 16, 'le').toArray('le', 3),
             [1, 2, 3]
           );
         });